Adds filter clearing logic to button on order cycle admin page #2479
Conversation
…as implementation
| @@ -6,6 +6,13 @@ angular.module("admin.orderCycles").controller "OrderCyclesCtrl", ($scope, $q, C | |||
| $scope.involvingFilter = 0 | |||
| $scope.scheduleFilter = 0 | |||
|
|
|||
| $scope.resetSelectFilters = -> | |||
There was a problem hiding this comment.
We should add a unit test for this new function in spec/javascripts/unit/admin/order_cycles/controllers/order_cycles_controller_spec.js.coffee
| @@ -6,6 +6,13 @@ angular.module("admin.orderCycles").controller "OrderCyclesCtrl", ($scope, $q, C | |||
| $scope.involvingFilter = 0 | |||
| $scope.scheduleFilter = 0 | |||
There was a problem hiding this comment.
Hi Adam, welcome! These two lines above are redundant as they are inside resetSelectFilters which is called just below, isn't it?
|
Hey @adam-conway ! Great to see your first PR :-) It seems you are pretty close to get it approved, do you think you can take into account the change requested so that we can move it forward into the pipe? Thanks a lot! |
sigmundpetersen
assigned sigmundpetersen and adam-conway and unassigned sigmundpetersen
| page.should have_selector "#listing_order_cycles tr.order-cycle-#{oc1.id}" | ||
| page.should have_selector "#listing_order_cycles tr.order-cycle-#{oc2.id}" | ||
| page.should have_selector "#listing_order_cycles tr.order-cycle-#{oc3.id}" | ||
|
|
There was a problem hiding this comment.
Should we take advantage of working on this to change to RSpec's new syntax (expect(page).to have(stuff)) ?
|
Hi @adam-conway, do you think you'll get time to make the requested changes so we can test and merge soon? We try to keep PRs in play to as small a number as possible, and this has been open for 3 weeks without change... |
|
Closing this PR due to inactivity (>1 month), and moving the issue back to dev ready. @adam-conway if you have time in the future feel free to reopen and finish it off 🙂 |
What? Why?
Closes #2362
On the admin order cycles page (/admin/order_cycles) there is a 'Clear All' button that doesn't currently do anything. This PR adds a method in the angular file to clear all of the filters when this button is clicked.
What should we test?
We should test that it does in fact clear all the filters if they've been set and all available order cycles show in the list.
Release notes
Fixes the clear all button on the admin order cycles page
Changelog Category: Fixed