Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace therubyracer with mini_racer #2424

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Replace therubyracer with mini_racer #2424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9fe1ce
Replace therubyracer with mini_racer
frank-west-iii Jul 3, 2018
d6c2a36
Blacklist libv8 version that breaks mini_racer
mkllnk Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@ group :assets do
gem 'compass-rails'
gem 'coffee-rails', '~> 3.2.1'

# See https://github.com/sstephenson/execjs#readme for more supported runtimes
gem 'therubyracer'
gem 'mini_racer'
# We found that the following version of libv8 breaks the compilation of mini_racer.
# Nothing else depends on libv8.
gem 'libv8', '!= 6.7.288.46.1'

gem 'uglifier', '>= 1.0.3'

Expand Down
11 changes: 5 additions & 6 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ GEM
addressable (~> 2.3)
letter_opener (1.6.0)
launchy (~> 2.2)
libv8 (3.16.14.19)
libv8 (6.3.292.48.1)
listen (3.0.8)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
Expand All @@ -479,6 +479,8 @@ GEM
mime-types (1.25.1)
mini_mime (1.0.1)
mini_portile2 (2.1.0)
mini_racer (0.1.15)
libv8 (~> 6.3)
momentjs-rails (2.5.1)
railties (>= 3.1)
money (5.1.0)
Expand Down Expand Up @@ -576,7 +578,6 @@ GEM
rdoc (3.12.2)
json (~> 1.4)
redcarpet (3.2.3)
ref (2.0.0)
representative (1.0.5)
activesupport (>= 2.2.2)
builder (>= 2.1.2)
Expand Down Expand Up @@ -657,9 +658,6 @@ GEM
stringex (1.3.3)
stripe (3.3.2)
faraday (~> 0.9)
therubyracer (0.12.3)
libv8 (~> 3.16.14.15)
ref
thor (0.20.0)
tilt (1.4.1)
timecop (0.9.1)
Expand Down Expand Up @@ -759,7 +757,9 @@ DEPENDENCIES
jwt (~> 1.5)
knapsack
letter_opener (>= 1.4.1)
libv8 (!= 6.7.288.46.1)
listen (= 3.0.8)
mini_racer
momentjs-rails
nokogiri (>= 1.6.7.1)
oauth2 (~> 1.2.0)
Expand Down Expand Up @@ -795,7 +795,6 @@ DEPENDENCIES
spree_i18n!
spree_paypal_express!
stripe (~> 3.3.2)
therubyracer
timecop
truncate_html
turbo-sprockets-rails3
Expand Down