Changed require syntax to fit jquery-ui-rails v<5.0 #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HugsDaniel
changed the title
HugsDaniel
changed the title
sauloperez
approved these changes
Jun 12, 2018
mkllnk
approved these changes
Jun 12, 2018
|
I just gave it a try and now I can log in and get to /admin! 🎉 Congrats @HugsDaniel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #2359
It seems that the require syntax for jquery-rails is not the one we used before (strange that it worked before with 2.x though). I replaced
require jquery-uiwithrequire jquery.ui.allinapp/assets/javascripts/admin/all.jsand app/assets/javascripts/darkswarm/all.js.coffee` and now it works fine. Also cart dropdown now appears.What should we test?
In the navbar, when clicking
Login, a modal should appear with the login form.Also, the cart button should appear in the navbar and when clicking it, the cart dropdown should appear.
How is this related to the Spree upgrade?
Syntax for requiring jquery-ui has to be changed in order to have login modal and shopping cart dropdown working properly.