Update activemerchant to v1.78 with new root cert #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
approved these changes
May 9, 2018
|
Spree 2.0 declares |
Fixes #2265. Most changes are in gateways we don't use, I believe. There has been a change in Stripe, but we use another implementation, I guess.
|
Testing notes
Not tested (we don't have a test method)
https://docs.google.com/document/d/16fYxSixnomWfkk7CSs-UneM9Q_fhqQg3WK6PDoztNCo/edit# |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #2265
Update ActiveMerchant including a new root certificate needed for at least Pin Payments.
What should we test?
Most changes are in gateways we don't use, I believe. There has been a
change in Stripe, but we use another implementation, I guess.
To verify my guesses and beliefs, we need to check the used payment gateways.
Release notes
Fixed the Pin Payments payment gateway which broke 4 May 2018 due to certificate updates.
How is this related to the Spree upgrade?
Newer versions of Spree may declare different dependencies on ActiveMerchant, but there should be no conflicts.