Use OFN's Spree fork of 2.0.4 to get fixes #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered the bug that spree/spree@3fd1535 fixes, which is needed to boot the app using Spree 2.0.4. This stems from openfoodfoundation#2236 (comment)
sauloperez
force-pushed
the
use-patched-spree-2.0.4
branch
from
f15b4f8 to
97e8adf
Compare
This was referenced Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
We encountered the bug that spree/spree@3fd1535 fixes, which is needed to boot the app using Spree 2.0.4. This means that we'll need to use Spree from our fork (branch
2-0-4-stable) and not the gem published in Rubygems.This stems from #2236 (comment)