Code

Stripe connect#1468

Code

Merged

RohanM merged 184 commits intoopenfoodfoundation:masteropenfoodfoundation/openfoodnetwork:masterfrom oeoeaio:stripe-connectoeoeaio/openfoodnetwork:stripe-connectCopy head branch name to clipboardSep 27, 2017

+3,895-432

Commits

Commits on Sep 23, 2017

• Create table for stripe accounts

  

  stveep

  authored and

  oeoeaio

  committed
  1db0bbe

• Starting Stripe integration

  

  stveep

  authored and

  oeoeaio

  committed
  df18329

• Add missing files

  

  stveep

  authored and

  oeoeaio

  committed
  3623325

• Stripe auth and callback working. Still need to process callback.

  

  stveep

  authored and

  oeoeaio

  committed
  0627984

• Callback creates a new StripeAccount with id and publishable key.

  

  stveep

  authored and

  oeoeaio

  committed
  03f590c

• Add Stripe Connect button (CSS) in admin/enterprises/:id/edit#payment_methods

  

  stveep

  authored and

  oeoeaio

  committed
  8bdf57d

• Add some logic to check for a connected Stripe Account in form

  

  stveep

  authored and

  oeoeaio

  committed
  b6292e2

• Correct spelling :)

  

  stveep

  authored and

  oeoeaio

  committed
  8ed983c

• Check CSRF, allow a Stripe account to be connected to more than one enterprise (but not vice versa)

  

  stveep

  authored and

  oeoeaio

  committed
  7fd8c59

• Monkey patching OAuth2 gem to include Stripe disconnection method

  

  stveep

  authored and

  oeoeaio

  committed
  eed11fa

• Remove CSRF check - doesn't work properly as implemented, but connect request should probably be changed to POST

  

  stveep

  authored and

  oeoeaio

  committed
  758f57a

• Worklow to disconnect Stripe from OFN admin interface

  

  stveep

  authored and

  oeoeaio

  committed
  05a69ff

• Stripe Helper specs

  

  stveep

  authored and

  oeoeaio

  committed
  1c69f2c

• De-associate accounts in response to webhook (not tested with a real deauth request yet)

  

  stveep

  authored and

  oeoeaio

  committed
  41607c5

• Move OAuth2 patching to an initializer

  

  stveep

  authored and

  oeoeaio

  committed
  0280e04

• Don't disconnect if the same Stripe account is connected to multiple Enterprises

  

  stveep

  authored and

  oeoeaio

  committed
  f22278d

• Add JWT encoding to state param

  

  stveep

  authored and

  oeoeaio

  committed
  1dcffa7

• Adding Stripe Connect information so we don't forget it later

  

  stveep

  authored and

  oeoeaio

  committed
  e52e04b

• Tidy up (temp) UI a bit

  

  stveep

  authored and

  oeoeaio

  committed
  e69b27a

• Add specs, fix redirect after requring relogin

  

  stveep

  authored and

  oeoeaio

  committed
  5ae473e

• Specify SHA-256 algorithm for JWT

  

  stveep

  authored and

  oeoeaio

  committed
  f83c7a8

• Specify SHA-256 algorithm for JWT in spec fixture

  

  stveep

  authored and

  oeoeaio

  committed
  5c43c75

• Tweaking redirects and links

  

  stveep

  authored and

  oeoeaio

  committed
  47df2dc

• Undo dodgy redirect changes and set spec to pending

  

  stveep

  authored and

  oeoeaio

  committed
  d374ab5

• Fix specs for travis

  

  stveep

  authored and

  oeoeaio

  committed
  da33570

• Fix some leftover refactoring from an earlier modification to enterprises controller (now not needed as moved to admin/enterprises)

  

  stveep

  authored and

  oeoeaio

  committed
  9ac638f

• Webhook processing changes: fix expected request data formatting

  

  stveep

  authored and

  oeoeaio

  committed
  a039286

• Change Stripe webhook handling to post request

  

  stveep

  authored and

  oeoeaio

  committed
  22e4a50

• Don't retrieve event from Stripe for a deauthorisation

  

  stveep

  authored and

  oeoeaio

  committed
  1450bfd

• Fix disconnect button formatting

  

  stveep

  authored and

  oeoeaio

  committed
  ae72ebe

• Add configuration example

  

  stveep

  authored and

  oeoeaio

  committed
  8588521

• Opening up restriction on activemerchant version by updating Spree ref

  Show description for b5a6bcd
  oeoeaio

  committed
  b5a6bcd

• Setting Stripe.api_key in an initializer rather than helper

  oeoeaio

  committed
  37f60bf

• Requesting read_write permission when authorizing Stripe standalone account

  oeoeaio

  committed
  99a7665

• Adding new StripeConnect payment gateway

  oeoeaio

  committed
  d500c20

• Very basic Stripe Connect payment method interface

  oeoeaio

  committed
  987ad0d

• Adding #status controller action for stripe accounts to fetch current info direct from Stripe

  oeoeaio

  committed
  f87f431

• Adding live stripe account status display to payment method create/edit interface

  oeoeaio

  committed
  5ad88f9

• Creating basic angular StripeJS wrapper service for requesting tokens

  oeoeaio

  committed
  5c16fef

• Adding StripeJS to checkout page

  Show description for 7c831c9
  oeoeaio

  committed
  7c831c9

• WIP: Storing Stripe card details for later use

  Show description for c97a140
  oeoeaio

  committed
  c97a140

• Bring in ability to store CreditCards against Users from Spree 2.3 (spree commit d470b31798f3).

  

  stveep

  authored and

  oeoeaio

  committed
  3b05b76

• Inject cards for current user into checkout and add selector dropdown to gateway partial.

  

  stveep

  authored and

  oeoeaio

  committed
  33b570b

• Check for current user before injecting credit cards

  

  stveep

  authored and

  oeoeaio

  committed
  298fd05

• Only show credit cards if previously saved, split credit card db migrations and tidy up serializer

  

  stveep

  authored and

  oeoeaio

  committed
  a1cad82

• Tidy up comment

  

  stveep

  authored and

  oeoeaio

  committed
  50c3d13

• Add default card, disable inputs when a card is selected

  

  stveep

  authored and

  oeoeaio

  committed
  300dc30

• Add some logic to check whether a saved card has been selected before making a request from Stripe

  

  stveep

  authored and

  oeoeaio

  committed
  12f4f2d

• spec for source attributes to pass for saved card

  

  stveep

  authored and

  oeoeaio

  committed
  627899b

• Add code to CheckoutController to construct card attributes when using an existing card (via https://github.com/spree/spree/blob/a818fbbecd1a2f0065771aa6055024549accfb47/core/app/models/spree/order…

  Show description for c4f9a5a
  

  stveep

  authored and

  oeoeaio

  committed
  c4f9a5a

• Making :source attr_accessible for Spree::Payment

  oeoeaio

  committed
  33a3db8

• Fix request and feature specs

  

  stveep

  authored and

  oeoeaio

  committed
  56295e5

• Stub Stripe requests in feature spec

  

  stveep

  authored and

  oeoeaio

  committed
  c6e50a3

• Basic UI for adding credit card details and getting a Stripe token without making a payment

  

  stveep

  authored and

  oeoeaio

  committed
  1449169

• Backend code to create Stripe customers and store their IDs in CreditCards. Page refresh not working

  

  stveep

  authored and

  oeoeaio

  committed
  c9c4680

• Add delete links, tidy up UI a bit (WIP), page refresh after adding still doesn't work

  

  stveep

  authored and

  oeoeaio

  committed
  25f48d9

• Add translations

  

  stveep

  authored and

  oeoeaio

  committed
  ddac179

• Keep timestamps as :null => false in schema

  oeoeaio

  committed
  d1779b9

• Cleaning up Stripe Connect request spec

  oeoeaio

  committed
  25907f9

• Adding request specs for case when using an existing card stored by Stripe for payment

  oeoeaio

  committed
  269a60b

• Removing unnecessary dependencies from OrdersCtrl

  oeoeaio

  committed
  b8c6da3

• Writing a new tabset component for front-end tabs

  Show description for ed5c650
  oeoeaio

  committed
  ed5c650

• WIP: rebuilding accounts page using tabs infrastructure

  oeoeaio

  committed
  1aebee0

• Rewriting styling for new tabs components

  oeoeaio

  committed
  778526a

• Refactoring credit cards interface, and backend logic

  oeoeaio

  committed
  f4c3fbf

• Adding translations for /account tabs

  oeoeaio

  committed
  532dc57

• Renaming account#history to account#transactions

  oeoeaio

  committed
  9733bb3

• Refactoring logic for displaying orders on the front-end account page

  oeoeaio

  committed
  b9d72ce

• Showing past orders under the orders tab

  oeoeaio

  committed
  4ef97aa

• Allow updating of account settings from account tabs interface

  oeoeaio

  committed
  fb5784f

• Ensure spec has Stripe.api_key set

  oeoeaio

  committed
  356dad7

• CreditCardController#destroy redirects to account#/cards

  oeoeaio

  committed
  63a15ec

• Adding message about having no saved cards to account/cards UI

  oeoeaio

  committed
  fdca1f6

• Adding required Stripe config variables to application.yml.example

  oeoeaio

  committed
  14f6ea4

• CheckoutController can render payment gateway error messages as json

  oeoeaio

  committed
  64009a2

• Refactoring CreditCardController, rendering card processing errors as json

  oeoeaio

  committed
  1d1e581

• Adding feature toggle config variable for Stripe Connect

  oeoeaio

  committed
  6499d17

• Implementing the Stripe Connect feature toggle

  oeoeaio

  committed
  f890927

• Set dummy Stripe API key for front-end credits cards feature spec

  oeoeaio

  committed
  e8636c0

• Replace text strings with variables in stripe request spec

  oeoeaio

  committed
  5d77ef5

• Handle Stripe token creation request failure

  oeoeaio

  committed
  01ce092

• Name StripeAccountController spec file correctly

  oeoeaio

  committed
  e6eb45b

• Refactoring StripeHelper into service objects

  oeoeaio

  committed
  ae2d3d3

• Clean up StripeConnect gateway

  oeoeaio

  committed
  c83755f

• Auto-correct rubocop offences for stripe-connect

  oeoeaio

  committed
  42dd584

• Make OAuth private methods actually private

  oeoeaio

  committed
  5b675cb

• Fix Lint/UselessAssignment offences for stripe-connect

  oeoeaio

  committed
  28ba05e

• Provide a sensible flash message when CreditCard#destroy action fails

  oeoeaio

  committed
  a68ae1f

• Use guard clauses where possible

  oeoeaio

  committed
  ecb7823

• Disable rubocop Style/PredicateName check against override of Spree method

  oeoeaio

  committed
  f3af36d

• Use nested module/class definitions instead of compact style

  oeoeaio

  committed
  e9d062a

• Kill empty space

  oeoeaio

  committed
  0e14704

• Provide a valid enterprise for building redirect path for Stripe Connect callback

  oeoeaio

  committed
  919e39f

• Add translations for Stripe connection flashes

  oeoeaio

  committed
  3efabf5

• Create payment from user-specified payment method when using existing card

  oeoeaio

  committed
  5c58d30

• Consolidate Stripe routes/actions into StripeAccountsController

  oeoeaio

  committed
  ffc99df

• Bump stripe gem version to 3.0.1

  Show description for ce65a9d
  oeoeaio

  committed
  ce65a9d

• Cleaning up oauth2 extension that is no longer required

  Show description for 692ccf0
  oeoeaio

  committed
  692ccf0

• Authorize StripeAccount#status using the account object

  Show description for 576e4db
  oeoeaio

  committed
  576e4db

• Provide a Stripe client_id for StripeAccountsController spec

  oeoeaio

  committed
  d2b6ba4

• Mock stripe_account_id for StripeAccount gateway specs

  oeoeaio

  committed
  44d172f

• Stub rather than set Stripe api_key in specs

  oeoeaio

  committed
  44ba499

• Fix stripe request spec by providing en enterprise_id

  Show description for ee92f46
  oeoeaio

  committed
  ee92f46

• Store card details submitted via checkout

  oeoeaio

  committed
  8901af8

• Include customer name in source attrs for Stripe checkout requests

  oeoeaio

  committed
  3591260

• Tweak UI for selecting an existing card at Checkout

  oeoeaio

  committed
  f317cee

• Ask customer about saving card details used in checkout

  oeoeaio

  committed
  3b78179

• Add hash navigation to admin Enterprise edit view

  oeoeaio

  committed
  862443e

• Use hash navigation to direct users to #/payment_methods from Stripe PM

  oeoeaio

  committed
  7c406f7

• Fix styling on jquery dialogs

  oeoeaio

  committed
  8cae874

• Add a modal to handle explanation of user's responsibilities before redirecting to Stripe

  oeoeaio

  committed
  589c2a1

• Use ng-cloak for admin/enterprises/edit form

  oeoeaio

  committed
  2f6493b

• Fix js for switching form partial for new admin payments

  Show description for a041164
  oeoeaio

  committed
  a041164

• Fix paypal source_form view

  Show description for fab893e
  oeoeaio

  committed
  fab893e

• Add admin views for Stripe payment methods

  Show description for 11daf89
  oeoeaio

  committed
  11daf89

• Use an explicit date format for PaymentsSerializer#updated_at

  oeoeaio

  committed
  1f8890b

• Restrict edit permissions on Stripe payment methods

  oeoeaio

  committed
  4865533

• Remove unused stripe action abilities

  oeoeaio

  committed
  98317e9

• Redirect to #/payment methods from stripe connect callback

  oeoeaio

  committed
  4e96487

• Add explanation about configuring Stripe API keys

  oeoeaio

  committed
  b31881b

• Add 'Stripe is in Beta' warning

  oeoeaio

  committed
  4fb1c7f

• Use guard clause in PaymentMethodsController#restrict_stripe_account_change

  oeoeaio

  committed
  6133b30

• Restrict the meaning of 'Saved Cards' to mean those with a payment profile

  oeoeaio

  committed
  41b7be9

• Fix typo in Stripe confirm modal

  oeoeaio

  committed
  cb08011

• Hide option to 'Remember this card' when an existing card is selected

  oeoeaio

  committed
  d5ab9eb

• Bump Stripe gem version

  

  stveep

  authored and

  oeoeaio

  committed
  511afa0

• Fix specs for saved credit cards: Add payment profile ID to fixture (now denotes that a card has been saved), check for current user to avoid error attempting to inject saved cards as a guest

  

  stveep

  authored and

  oeoeaio

  committed
  f065cbe

• Add/remove comments from PR feedback

  

  stveep

  authored and

  oeoeaio

  committed
  da5c907

• Separate files for Payment Method serializers

  

  stveep

  authored and

  oeoeaio

  committed
  0a12f78

• Apply style guide

  

  mkllnk

  authored and

  oeoeaio

  committed
  5b7e2f7

• Re-generate rubocop_todo

  

  mkllnk

  authored and

  oeoeaio

  committed
  926f196

• Use Stripe Elements instead of StripeJS: https://stripe.com/docs/elements

  

  stveep

  authored and

  oeoeaio

  committed
  56ff877

• Checkout switched to Stripe Elements from StripeJS

  

  stveep

  authored and

  oeoeaio

  committed
  15ed4c3

• Modify to use Stripe Elements to manually add cards in Account page. Remove StripeJS service

  

  stveep

  authored and

  oeoeaio

  committed
  74a7cb8

• Restyle add card form

  

  stveep

  authored and

  oeoeaio

  committed
  6690f2e

• Add 'publishable_key' property to Stripe module (enables stubbing)

  oeoeaio

  committed
  746c2ff

• Move StripeElements element to an AngularJS directive, mount from there

  oeoeaio

  committed
  65ab83a

• Initialize Stripe object only if a publishable_key has been defined

  oeoeaio

  committed
  6938537

• Update feature specs to look for Stripe Elements element

  oeoeaio

  committed
  1aa477c

• Rewrite js unit specs for Stripe Elements service

  oeoeaio

  committed
  f9df4d4

• Convert problematic embedded shopfronts feature spec into request spec

  oeoeaio

  committed
  2ed5e14

• Move PaymentMethodSerializer to correct path

  oeoeaio

  committed
  e487217

• Add ng-model directive to save credit card checkbox

  Show description for 7b45646
  oeoeaio

  committed
  7b45646

• Stop setting host for url helpers in specs

  oeoeaio

  committed
  dd56e03

• Allow Stripe-based payments to be voided (refunded)

  oeoeaio

  committed
  ecef905

• Clean up jquery dialog styling

  oeoeaio

  committed
  742dd0b

• Hide 'save credit card' checkbox for guests

  oeoeaio

  committed
  2f153d7

• Prevent Stripe payment methods without account owners from being saved

  oeoeaio

  committed
  ca1987f

• Hide Stripe payment methods without a preferred_enterprise_id from the front-end

  oeoeaio

  committed
  0cd4398

• Add border to Stripe Elements input, make text larger

  oeoeaio

  committed
  3a0b47c

• Rearrange new card inputs on account page

  oeoeaio

  committed
  19213a5

• Fix Admin::PaymentsController spec

  oeoeaio

  committed
  9832966

• Call single-use before_filters from actions instead

  oeoeaio

  committed
  22bbe29

• Add missing controller specs for CreditCardController #destroy

  oeoeaio

  committed
  4464a85

• Remove new credit card initialisation logic from Spree::UsersController#show

  oeoeaio

  committed
  f6c3a2a

• Refactor logic for creating a payment profile from a Stripe token into a service object

  oeoeaio

  committed
  a74c502

• Create a Struct for Stripe Connect settings once rather than on each request

  oeoeaio

  committed
  a2dee8d

• Rename Stripe existing_card param key to existing_card_id

  oeoeaio

  committed
  61feb2b

• Use expect syntax instead of should

  oeoeaio

  committed
  08c723b

• Add documentation to StripeConnectSettings controller

  oeoeaio

  committed
  5cba635

• Use find_by_id instead of find in EnterpriseController

  oeoeaio

  committed
  620721c

• Refactor ProfileStorer, call options as a separate method

  oeoeaio

  committed
  0e42c1c

• Use guard clause

  oeoeaio

  committed
  0bbaafb

• Extract filters for available PMs into service object

  oeoeaio

  committed
  1cd1e9d

• Fix rubocop issues

  oeoeaio

  committed
  098afc6

• Add missing translation referenced from spree_auth_devise

  oeoeaio

  committed
  fbda1a2

• Make request stubs less brittle by using regex

  oeoeaio

  committed
  d2096cf

• Fix broken Stripe checkout spec

  oeoeaio

  committed
  e14b017

• Use lowercased cc_type in CreditCard service

  oeoeaio

  committed
  4785f3e

• Add basic validation to credit card form on account page

  oeoeaio

  committed
  34b109c

• Fix flaky OrderSerializer spec

  Show description for 393a4ef
  oeoeaio

  committed
  393a4ef

• Configure StripeElements service to map cc_type to that used by activemerchant

  oeoeaio

  committed
  0f19be4

• Ensure cart_spec runs in context where backorders are disabled

  oeoeaio

  committed
  7d2deca

• Update deauthorize webhook to latest version of API

  oeoeaio

  committed
  d3566f9

• Refactor Stripe::AccountConnector

  Show description for 665749d
  oeoeaio

  committed
  665749d

• Show more helpful payment processing error in checkout

  oeoeaio

  committed
  7c82fa3

• Expose Stripe token creation error messages in Checkout

  oeoeaio

  committed
  ba61f94

• Update Bogus Gateway error message in checkout spec

  oeoeaio

  committed
  7ba99c0

• Prevent Stripe-based payment methods that are not linked to a StripeAccount from displaying in the checkout

  oeoeaio

  committed
  90007d7

• Update deauthorize webhook to latest version of API (again)

  oeoeaio

  committed
  dd3d205

• Allow destruction of StripeAccounts even if deauthorise request fails

  Show description for db5503d
  oeoeaio

  committed
  db5503d

• Respond to Stripe webhook with status of 204 if specified account is not found

  oeoeaio

  committed
  e486dbd

• Set transaction fee adjustments to ineligible if payment is invalid or failed

  oeoeaio

  committed
  a09a54e

• Remove the 'confirm' step from the order checkout flow

  Show description for 75ec77d
  oeoeaio

  committed
  75ec77d