Activates admin_style_v3 for 25 per cent users #12686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipefurtad0
added
the
feature toggled
filipefurtad0
added
pr-staged-fr
12 tasks
dacook
approved these changes
Jul 22, 2024
| def up | ||
| Flipper.enable_percentage_of_actors(:admin_style_v3, 25) | ||
| end | ||
| end |
There was a problem hiding this comment.
Although it's only intended for server environments, it won't hurt for this to run on dev. I just tested on dev and it remains fully enabled:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
What should we test?
Under
/admin/feature-toggle/features/admin_style_v3:First, enable the feature for:
admins)Before the PR, the percentage should in principle be 0%; if not, note which percentage is enabled for the staging server:
After the PR, the percentage should go up to 25% - it should overwrite any previously set percentage:
It should not change the enabled user and group.
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates