[inventory] Fix product sorting #12680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the ordering by producer got lost in some rebase.
rioug
added
the
user facing changes
dacook
approved these changes
Jul 17, 2024
| permissions_list: [:create_variant_overrides]) | ||
|
|
||
| result = query.products_for_producers | ||
| expect(result).to eq([product_b3, product_b1, product_b2, product3, product4]) |
There was a problem hiding this comment.
At first glance, it's not easy to see if this is correct or not. We could name the variables the same as the record names to make it clearer.
Not that I'm complaining, at least we have a spec now!!
dacook
added
the
bug-s3
filipefurtad0
added
no-staging-FR
|
Hey @rioug, This looks good. Before staging the PR, one can see that both products and variants are not sorted alphabetically; this changes after staging the PR:
We can see that first, it is ordered by producer (I've changed the product name
And that both products and variants are ordered within each producer / product. Merging! |
filipefurtad0
merged commit 3bd5ae2
into
openfoodfoundation:master
60 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The product sorting in the inventory got broken after the product refactor, where the supplier got moved to the variant, this PR re add the sorting. Product are now sorted by producer alphabetically and product alphabetically.
What should we test?
This may help with #12679, but it might be easiest to wait and test the replication case given in production.
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates