Changed a single line in turbo to insert cloned products after the original product #12675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacook
added
the
feature toggled
chahmedejaz
approved these changes
Jul 16, 2024
|
Hey @zsoltiNagy , I believe this is your first contribution, right? Welcome! 👋 Before this PR, cloning a product inserts the clone above the original (please ignore the save changes banner, in the pic below, it's not relevant here):
After this PR, reloading the page, displays the clone below the original:
And creating another clone correctly adds the new product beneath it:
This looks great! Merging 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a single line in turbo to insert cloned products after the original product
This small change is needed to address the issue brought up in #12623
What should we test?
Only the visual behavior.
feature toggle the admin_style_v3
Visit /admin/products
Clone a product, see if it appears below or above the original, it should appear below it
User facing changes
API changes (V0, V1, DFC or Webhook)
Technical changes only
Feature toggled
Dependencies
none
Documentation updates
none