Improve spec for Spree::Order#finalize! #12662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more realistic and robust. Don't mock the class under test (even though `touch` is actually provided by Active Record).
The spec was asserting on all shipments of the order but there were one. In consequence, the spec didn't assert anything. Now I set up a shipment that is asserted on. I'm stil not sure how useful this spec is though.
The next test case wasn't asserting anything as well. The referenced method `decrease_stock_for_variant` doesn't actually exist.
It's more realistic this way.
mkllnk
added
the
technical changes only
mkllnk
commented
Jul 11, 2024
Comment on lines
-232
to
-235
| order.shipments.each do |shipment| | ||
| expect(shipment).to receive(:update!) | ||
| expect(shipment).to receive(:finalize!) | ||
| end |
There was a problem hiding this comment.
Sorry for the typo in the commit message. order.shipments was empty.
rioug
approved these changes
Jul 12, 2024
dacook
approved these changes
Jul 15, 2024
| order.reload | ||
| }.to change { | ||
| order.completed_at | ||
| }.from(nil) |
There was a problem hiding this comment.
Nice way to test this. I probably would have gone down the unnecessary task of freezing time and checking it changed to the current time..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I was looking at existing specs around stock allocation when an order is completed. And I stumbled across some ineffective specs of the Order model which I fixed here.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates