Filter out Stripe client_id

[dacook]

What? Why?

• Follow-up from Bump stripe from 10.3.0 to 10.5.0 #12018

What should we test?

Stripe specs pass

Dependencies

Ideally we'd deal with this before the next Stripe version bump.

[dacook]

As an aside, I'm actually not sure why we need to filter out "bogus_customer" and "bogus_account", as those are stored in .env.test.

[mkllnk]

Excellent!

[filipefurtad0]

As an aside, I'm actually not sure why we need to filter out "bogus_customer" and "bogus_account", as those are stored in .env.test.

I agree, we don't. But when we send out the "real_customer" and "real_account" to Stripe then the corresponding replies (cassettes) may contain these, too. So I think it's ok to include this in the VCR config and scramble them out 👍

We set these bogus credentials on .env.test so that the CI has all the data (although bogus data!) to send out request. Thing is, it does not get to send them, because the cassettes already exist.

This is my understanding of it - I hope I've understood your comment correctly.

[filipefurtad0]

🙌

[dacook]

I agree, we don't. But when we send out the "real_customer" and "real_account" to Stripe then the corresponding replies (cassettes) may contain these, too. So I think it's ok to include this in the VCR config and scramble them out 👍

I didn't have a "real" customer or account ID configured when I re-recorded the cassettes, I just had the default "bogus" ones from .env.test which worked fine. If there is a "real" ID returned in the responses, then they haven't been filtered out. (I believe it filters based on an exact match of the value, that is a simple find/replace).

Anyway, I don't see any harm in filtering them out like this.