Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFC] Patch dfc connector parser to improve SKOS concept parsing #11893

Merged

Conversation

rioug
Copy link
Collaborator

@rioug rioug commented Dec 4, 2023

What? Why?

Apply the changes described here : datafoodconsortium/connector-codegen#10
It will eventually be removed when upstream changes get merged.

What should we test?

Passing specs

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

@rioug rioug force-pushed the 10809-patch-dfc-connector-parser branch from 36f2fc0 to 021e292 Compare December 4, 2023 02:57
@rioug rioug changed the title patch dfc connector parser [DFC] Patch dfc connector parser to improve SKOS concept parsing Dec 4, 2023
@rioug rioug added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Dec 4, 2023
@rioug rioug self-assigned this Dec 4, 2023
@rioug rioug marked this pull request as ready for review December 4, 2023 03:03
@rioug rioug requested a review from mkllnk December 4, 2023 03:04
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I hope that the codegen PR will be merged soon but who knows.

@mkllnk mkllnk merged commit 89b6b18 into openfoodfoundation:master Dec 4, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants