Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully Enable Vouchers Feature Toggle by Default #11831

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fully Enable Vouchers Feature Toggle by Default #11831

merged 2 commits into from
Nov 21, 2023

Conversation

chahmedejaz
Copy link
Collaborator

What? Why?

What should we test?

  • After the deployment, go to the Flipper UI
  • Please validate that the feature toggle for the vouchers has been fully enabled.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

rioug
rioug approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help !

@drummer83 drummer83 self-assigned this Nov 21, 2023
@drummer83 drummer83 added pr-staged-au staging.openfoodnetwork.org.au pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-au staging.openfoodnetwork.org.au labels Nov 21, 2023
@drummer83
Copy link
Contributor

Hi @chahmedejaz,
Thanks for another pull request!

Switching OFF to ON

I staged this PR on our AU server, where I had the feature toggle switched OFF before:
grafik

After staging the toggle was switched ON and vouchers were available:
grafik

grafik

Switching ON to ON

I also staged this PR on our UK server, where I had the feature toggle switched ON before:
grafik

After staging the toggle was still switched ON and vouchers were available:
grafik

grafik

Result

Seems to work well! 💪
Thanks again! Merging! 🎉

@drummer83 drummer83 merged commit 8ae9399 into openfoodfoundation:master Nov 21, 2023
54 checks passed
@drummer83 drummer83 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rioug rioug rioug approved these changes

@mkllnk mkllnk mkllnk approved these changes

Assignees

@drummer83 drummer83

@chahmedejaz chahmedejaz

Labels
None yet
Projects
OFN Delivery board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activate voucher feature toggle by default
4 participants
@chahmedejaz @drummer83 @mkllnk @rioug