Feature toggled specs #11821
Merged
Feature toggled specs #11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
added
the
technical changes only
mkllnk
force-pushed
the
feature-toggled-specs
branch
from
ddc1ce7 to
f905967
Compare
It's simple this way and we have one place to add logic to when needed (see next commit).
There was one case where a typo meant that the desired feature wasn't active and tests were not testing the right code path. Using this new syntax should prevent that. * openfoodfoundation#11705
mkllnk
force-pushed
the
feature-toggled-specs
branch
from
f905967 to
6f3bee7
Compare
filipefurtad0
approved these changes
Nov 20, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I'm introducing a new tag to activate a feature for certain spec blocks. And it checks that the feature is actually defined in the code base. This could have prevented:
There's nothing to enforce the use of this helper tag and therefore user error is still possible, just less likely. We do need the original version of
Flipper.enableto test our feature toggle logic but in most cases we can just use the new tag.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates