Adds coverage on order confirmation page #11682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to the changes from PRs openfoodfoundation#11668 and openfoodfoundation#11114.
filipefurtad0
added
the
technical changes only
abdellani
approved these changes
Oct 19, 2023
dacook
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Great!
I didn't know you can use a before block with it_behaves_like. It's interesting to note that while all the comparisons are similar, you've chosen to build some into the shared_example, and copy some in the before block.
I don't think it matters either way, and it seems like a good compromise to me 👍
|
|
||
| shared_examples "order confirmation page" do |paid_state, paid_amount| | ||
| it "displays the relevant information" do | ||
| expect(page).to have_content paid_state.to_s |
There was a problem hiding this comment.
I think to_s shouldn't be necessary because it's already a string comparison. But it's no big deal :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers the changes introduced in PRs #11668 and #11114.
What? Why?
The UI is tested according to the three scenarios described in #11668.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates