Hide old products screen when admin_style_v3 enabled #11660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dacook
force-pushed
the
products_v3_path
branch
from
a3d8fed to
a555cb5
Compare
The feature toggle will determine which bulk products screen shows. An additional products_old path is also temporarily added for easy reference. Later, when the old screen is full removed, we'll probably rename the _v3 classes to tidy up.
dacook
force-pushed
the
products_v3_path
branch
from
a555cb5 to
655c16c
Compare
dacook
added
the
technical changes only
|
Niiice! All tests are passing. thanks @dacook merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature toggle will determine which bulk products screen shows.
An additional
/admin/products_oldpath is also temporarily added for easy reference.What? Why?
What should we test?
Disable
admin_style_v3feature toggle/admin/products. Observe old screen.Enable
admin_style_v3feature toggle/admin/products. Observe new screen./admin/products_old. Observe old screen.Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates