Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart state orders not appearing orders page #11121

Conversation

filipefurtad0
Copy link
Contributor

What? Why?

  • Adds a pending system spec (/orders page)
  • Adds a request spec, documenting the current behavior: it seems all cart orders can be fetched by the API request.

What should we test?

  • green build

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

spec/requests/api/orders_spec.rb Outdated Show resolved Hide resolved
@filipefurtad0 filipefurtad0 force-pushed the cart_state_orders_not_appearing_orders_page branch from 4597e36 to a295672 Compare July 3, 2023 10:51
@filipefurtad0 filipefurtad0 force-pushed the cart_state_orders_not_appearing_orders_page branch from a295672 to e547e73 Compare July 3, 2023 10:52
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rioug
Copy link
Collaborator

rioug commented Jul 4, 2023

@filipefurtad0 do we need to wait for a fix from #11120 before merging ?

@jibees
Copy link
Contributor

jibees commented Jul 4, 2023

@filipefurtad0 do we need to wait for a fix from #11120 before merging ?

If the spec has been reviewed, I'd say no!

@filipefurtad0
Copy link
Contributor Author

If the spec has been reviewed, I'd say no!

Agree, the test on the:

So I'd say we can merge :-)

@rioug
Copy link
Collaborator

rioug commented Jul 6, 2023

Merging !

@rioug rioug merged commit fb3c99e into openfoodfoundation:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants