-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for deploying to staging #11031
Add workflow for deploying to staging #11031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. Thank you.
Do you know why I can't see the box with CI which should be at the bottom of a PR page ? |
That's pretty weird. It was there last night when I went to bed, and now it's gone. Maybe a temporary github glitch? 🤷♂️ |
I think it goes away when PR is merged, no? |
Yes, I think so @sigmundpetersen 👍 Thanks for this change @Matt-Yorkley 🙏 I'm playing around with the basic functionalities, some initial thoughts:
Or for staging-UK, an example here:
Worked nicely for master, which can be found under However, I think we're only able to select some branches - or am I looking in the wrong place? For example, I'm not finding a way to trigger a manual deploy on mkllnk:ruby3.1, other than the label process. Also, we can see the |
Yeah the UX around Github Actions seems a bit clunky. And yes it's currently not working with the labelling thing, I need to tweak it a bit and figure out why. It seems like maybe it's ignoring the secrets in some cases and not others? Also it looks like when manually triggering a deployment it only works if the branch you're choosing already contains the new workflow(?), which is a bit annoying. So it's currently present in
Yeah I think we'll want to deploy the merge commit for PRs in that case instead of the branch in the external repo (which should work with the labelling-trigger on pull requests, once they're fixed). It's getting there but it's not finished yet 👍 |
What? Why?
Adds a new workflow for deploying to staging servers via github actions.
What should we test?
The funny thing about workflows is you can't see if they work until after they're merged...
It should be possible to trigger a deployment by either:
pr-staged-uk
orpr-staged-fr
orpr-staged-au
label to a pull requestRelease notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.