[wip] Backoffice UI Uplift

[dacook]

What? Why?

This is a shared development branch. We will likely rebase/rewrite history before submitting a PR to master.

• [BUU] As an enterprise user, I want to know if I have products in my catalogue #10679

Log of changes:

1. DC: Add products_v3 page with simple table and styling
2. JB: Add async loading of products table with spinner

What should we test?

• Visit ... page.

Release notes

Changelog Category: 😎 Feature toggle

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[jibees]

There are some merge commits that should probably be removed to clean git history...

I've rebased onto master, seems fine.

[dacook]

Rebased on top of #11123

[jibees]

@dacook I'd be happy if we could create PRs with commits from this PR in order to close this PR/branch, as I don't think it's still relevant

[jibees]

I've created a PR with 4 commits that tweak the dropdown filters to make them compliant to v3 version: #11275

[jibees]

@dacook I'd propose you two create one (or more?) PR with the remaining commits of this PR in order to close it after that. Let me know what you think about it! 🙏

[jibees]

@dacook
spec/system/admin/products_v3/products_spec.rb:46 is failing actually. don't know why ... maybe a bad conflict resolution?

[dacook]

This is really strange and had me stumped earlier. I think I've narrowed it down now, see latest commit. It seems due to an inconsistency between operating systems!!
Admittedly, I'm on an old macOS 10.15, and am overdue for an upgrade. It seems the behaviour might be fixed in later versions, so I'm wondering what version you use?

And secondly, unfortunately it seems the other system specs on this page seem quite flaky, I guess due to StimulusReflex..

[dacook]

Thanks for confirming. The spec actually passes in CI, so I guess Postgres on Macs behaves differently here, which is quite strange, I'm surprised we haven't encountered this before, I guess our sorting specs don't cover this case (eg this spec is just uppercase).

I think I'll just update the spec to avoid comparing lower/uppercase letters, and add a note on https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup%3A-OS-X . Sound reasonable?

BTW A different spec did fail in the last build (see products_spec.rb:119), but I believe it's flaky.

[jibees]

I think I'll just update the spec to avoid comparing lower/uppercase letters, and add a note on https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup%3A-OS-X . Sound reasonable?

Yes, I guess so.

[jibees]

BTW A different spec did fail in the last build (see products_spec.rb:119), but I believe it's flaky.

Pass locally. 👌

[jibees]

@dacook
Do you intend to merge this branch? I'm a bit confused, and at the same time worried about this branch that's always open.
Thanks for your insight.

[dacook]

Ugh, yes sorry I wasn't really thinking about that.

Maybe the process we need is to create PRs more often, and request a review from each other first.
If your commits are ready for review, perhaps we can submit this PR for review now, as it is?

[jibees]

In order to finally close this one, I've opened two PRs: #11400, and #11401

After merging those two PRs, this one should not contains commits, and should therefore be closed.