Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vouchers] Updates warning_forfeit_remaining_amount default message #10859

Conversation

filipefurtad0
Copy link
Contributor

What? Why?

Changes the default message when adding a voucher, on possibly forfeiting the remaining amount.

Context here.

What should we test?

  • As an enterprise, create a voucher.
  • As a customer, visit the shop, add some items to the cart (value should be below 10)
  • On the payment step, add a voucher
  • The warning should read: Note: if your order total is less than your voucher you may not be able to spend the remaining value.

image

Release notes

Changelog Category: User facing changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 changed the title Updates warning_forfeit_remaining_amount default message [Vouchers] Updates warning_forfeit_remaining_amount default message May 18, 2023
@filipefurtad0 filipefurtad0 force-pushed the change_voucher_default_message_en branch from d97b1de to c99829e Compare May 18, 2023 11:11
@drummer83 drummer83 self-assigned this May 23, 2023
@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label May 23, 2023
@drummer83
Copy link
Contributor

Hi @filipefurtad0,
Thanks for this improvement! 💪

Here is the warning BEFORE staging your PR:
image

And here it is AFTER staging your PR:
image

Looking good, thanks! Merging! 🎉

@drummer83 drummer83 merged commit b56b36f into openfoodfoundation:master May 23, 2023
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants