Preserve encoding of stored reports

[mkllnk]

What? Why?

• Closes [background_reports] ActionView::Template::Error in admin/reports#show #10758

Active Storage reads stored strings as ASCII and that can clash with Rails' default UTF-8 encoding when special characters are present.

What should we test?

• Find a staging server that fails with master, e.g. au-staging
• Activate background reports.
• Render an On Screen report.
• It should display as normal.

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[rioug]

Looks good 👍

[dacook]

Well done!

[drummer83]

Hi @mkllnk,

Thanks for this one. I tested this on staging AU. The data has some ä, ö, ü which may be critical for this PR.

I tested this using the following settings:

• Running Order Cycle Supplier Total
• as super admin user
• with no date restrictions

Before staging

Background Reports active: Error 500 (after 17 s) ❌
Bugsnag link

ActionView::Template::Error admin/reports#show 
incompatible character encodings: UTF-8 and ASCII-8BIT

Background Reports not active: OK (after 17 s) ✔️

After staging

Background Reports active: OK (after 18 s) ✔️

Background Reports not active: OK (after 16 s) ✔️

Conclusion

This seems to solve the UTF vs. ASCII error. I didn't test more reports but I think we are safe because we still have the feature toggle.

Thanks again! Merging! 🚀