-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin, create new order: distributor and order cycle are now mandatory on step 1 (aka the set_distribution step) #10712
Conversation
0e40e1e
to
347cbba
Compare
That handles the step when distributor and order_cycle must be selected
347cbba
to
abe77ac
Compare
This will be handled by validation on set_distribution action
and use the same method `OrdersController#set_distribution`
distribution means tuple: distributor + order cycle
abe77ac
to
722c660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. There's just one suggestion below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Hi @jibees, I have reproduced the issue before staging first. The situation is a bit different now, because when the issue was created, we still had the product selection first and then the customer selection afterwards. This is the other way round now. Additionally the customer selection doesn't return any results if no distributor is selected on the very first step. If information is missing, one of the following errors will be shown: I didn't manage to see any endless spinners of error 500. Excellent! |
What? Why?
Context: Admin section, creating a new order
This PR make the distribution step (ie. the one that set both distributor and order_cycle for an order) mandatory when creating a new order in the admin backoffice.
/distribution
set_distribution_step
context/distribution
when no distributor or order_cycle are setCan't access next step-s (via
Next
button, or links on the side) until distributor and order cycle are setCan access next steps when distributor and order cycle are set
What should we test?
As an admin, check that when creating a new order, we can't go to next steps until distributor and order_cycle are set for this new order
Release notes
Changelog Category: User facing changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates