Disables Flipper memoization for test environment (Fixes Flipper middleware warning in Rails 7)

[filipefurtad0]

On the rails 7 branch The build was displaying the error - Flipper::Middleware::Memoizer appears to be running twice. - This commit tries to fix that

The error mentions this approach https://github.com/jnunemaker/flipper/pull/523, but I could not really make flipper.preload work. I think one possible approach could be disabling memoization for the test environment.

Thinking out loud - If we wish to keep it we can as well enable it on our base spec helper by adding:

# in base_spec_helper.rb

RSpec.configure do |config|
  config.before(:each) do
    Flipper.instance = Flipper.new(Flipper::Adapters::Memory.new)
  end
end

What? Why?

• prepares for Rails 7

What should we test?

Commit to be cherry picked into mkllnk:rails7 branch -> no testing needed here, just a

• Green build in Rails 7 branch

Or

If we wish to merge it with master we should:

Test flipper:
Log in as a superadmin and verify that:

• all features are listed
• enabling/disabling features works as before

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[mkllnk]

Cool, I didn't notice. I looked further into this and found that it's not the Rails upgrade causing this. It's just that the Rails upgrade also contains a Flipper upgrade and Flipper has some "breaking" changes:

• https://github.com/jnunemaker/flipper/blob/main/Changelog.md#0210

We can actually upgrade flipper without Rails. I don't know why Dependabot isn't suggesting it but it may be because there are several gems that need to be updated together. I'll draft a PR.

[mkllnk]

I have an alternative solution in a new pull request. Are you happy to close this one?

[filipefurtad0]

I have an alternative solution in a new pull request. Are you happy to close this one?

Sure @mkllnk , thank you for picking this up! 👍