Remove unused angular directives

[cillian]

What? Why?

This partially address #8700 and removes three unused angular directives.

• The showMore directive was introduced here but it looks like it was never used, see a, b, c.
• The fillVertical directive was introduced here but was no longer used after a3660df
• The singleLineSelectors was no longer used after 532e27b

What should we test?

Check the directives are not called anywhere here...

https://github.com/openfoodfoundation/openfoodnetwork/search?q=fill-vertical
https://github.com/openfoodfoundation/openfoodnetwork/search?q=show-more
https://github.com/openfoodfoundation/openfoodnetwork/search?q=single-line-selectors

Release notes

Changelog Category: Technical changes

[jibees]

# For now, this component is not being used.

7 years ago.

Thanks! 🙏 ☺️

[jibees]

Thanks!

I saw that:

openfoodnetwork/app/webpacker/css/darkswarm/_shop-filters.scss

Line 164 in 1ca305a

// singleLineSelectors directive provides a drop-down that can overlap

What do you think?

[cillian]

Thanks @jibees what about this instead? c000010

We might be able to get rid of the CSS .filter-row class entirely, it's used here and here but I'm not 100% sure.

[jibees]

I removed that class and tested:

I've tested, and I can't see any difference...

So i've commit/pushed. Tell me what do you think about it!

c000010

[cillian]

Looks good to me, it doesn't seem to be used anywhere ✔️

[jibees]

LGTM! Thanks @cillian !

[filipefurtad0]

Hey @cillian @jibees ,

I'm not sure what else would be needed from the testing side of things. I've had a quick smoke test around:

• This commit seems to relate to /customers page: I've spotted no change in rendering or behavior
• As pointed here, I've had a look at the shop front and different filter selections (shop and product categories) - all as before.

I'd say this is good to go? I'll more to ready to go, feel free to drop a line if anything else is needed on this one!

[jibees]

Thanks @filipefurtad0 !
Since those directives were unused, it's rather difficult to know how to test ;)

I'd say Ready to go then!!