Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates BOM system spec - prepares for #10123 #10168

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Dec 16, 2022

What? Why?

Adds a spec to cover the pre-selection of the date-range, the ability to combine OC and specific dates, and the filter/clear filters functions - as per #10123.

This is set as pending/draft and is blocked by #10123. Will be updated after this PR is merged.

Following the notes on what to test, this PR updates the spec to assure that:

  • Check that orders are first loaded, according to filters
  • Change any filter: check that orders did not change
  • Click "Filter Result": orders should change
  • Click "Clear Filters": filters should be reset to default values

What should we test?

Green build

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 marked this pull request as draft December 16, 2022 14:50
@filipefurtad0 filipefurtad0 force-pushed the updates_bom_spec branch 3 times, most recently from e60b8c9 to 39bd9e0 Compare December 16, 2022 15:34
@mkllnk
Copy link
Member

mkllnk commented Dec 29, 2022

Can be updated now.

@filipefurtad0 filipefurtad0 marked this pull request as ready for review January 2, 2023 13:07
@filipefurtad0
Copy link
Contributor Author

Updated and green 🟢
Moved to code review.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mkllnk mkllnk merged commit 4a250f4 into openfoodfoundation:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants