Bump stripe from 7.1.0 to 8.0.0

[dependabot]

Bumps stripe from 7.1.0 to 8.0.0.

Release notes

Sourced from stripe's releases.

v8.0.0

• #1144 Next major release changes

Breaking changes that arose during code generation of the library that we postponed for the next major version. For changes to the Stripe products, read more at https://stripe.com/docs/upgrades#2022-11-15.

"⚠️" symbol highlights breaking changes.

See the changelog for more details.

v7.2.0-beta.5

• #1139 API Updates for beta branch
  • Updated beta APIs to the latest stable version
• #1135 API Updates for beta branch
  • Updated stable APIs to the latest version

See the changelog for more details.

v7.2.0-beta.4

• #999 DESCRIBE CHANGES HERE (try to use the same style, tense, etc. as the other entries)

See the changelog for more details.

v7.2.0-beta.3

• #1129 API Updates for beta branch
  • Updated stable APIs to the latest version
  • Add FinancingOffer, FinancingSummary and FinancingTransaction resources.

See the changelog for more details.

v7.2.0-beta.2

• #1127 API Updates for beta branch
  • Updated stable APIs to the latest version
  • Add support for the beta Gift Card API.

See the changelog for more details.

v7.2.0-beta.1

• #1122 API Updates for beta branch
  • Updated stable APIs to the latest version
  • Stripe-Version beta headers are not pinned by-default and need to be manually specified, please refer to beta SDKs README section

See the changelog for more details.

Changelog

Sourced from stripe's changelog.

8.0.0 - 2022-11-16

• #1144 Next major release changes

Breaking changes that arose during code generation of the library that we postponed for the next major version. For changes to the Stripe products, read more at https://stripe.com/docs/upgrades#2022-11-15.

"⚠️" symbol highlights breaking changes.

Deprecated

• The save method is deprecated. Prefer the static update method that doesn't require retrieval of the resource to update it.

  # before
  refund = Stripe::Refund.retrieve("re_123")
  refund.description = "Refund description"
  refund.save
  after
  Stripe::Refund.update("re_123", description: "Refund description")

⚠️ Removed

• Removed deprecated Sku resource.
• Removed deprecated Orders resource.
• Removed deprecated delete method on Subscription resource. Please use cancel method instead.

  # before
  Stripe::Subscription::delete("sub_12345")
  after
  Stripe::Subscription::cancel("sub_12345")

Commits

• 24312f9 Bump version to 8.0.0
• a0935c2 Next major release changes (#1144)
• 6dc0095 Disable AsciiComments rule (#1142)
• c2bb4db Codegen for openapi v204 (#1138)
• 46eca72 Do not run Coveralls if secret token is not available (#1137)
• 2dec63e Update request_end instrumentation example (#1095)
• af6fb06 Merge pull request #1126 from stripe/anniel-coveralls
• 4d87c3a Restart CI due to Github Actions incident
• dc93d96 Change check to 3.1.
• f647412 Add comment and change to starts_with
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

What should we test?

This is a major version change for Stripe, so we should manually test all Stripe payment related functions extensively.

[jibees]

Ouch, this is a major version change even if Breaking changes that arose during code generation of the library that we postponed for the next major version.

stripe/stripe-ruby#1144
https://stripe.com/docs/upgrades#2022-11-15

[jibees]

@filipefurtad0 @mkllnk what do you guys think about this one?

[filipefurtad0]

Hum.. It's hard to trust our green build, in what Stripe concerns. I'm not sure our implementation of Stripe touches these changes, so I think we'd need extensive manual testing to find out.

[dacook]

From what I can see in the changelog, the only changes are removed deprecated code (breaking), and deprecated (not removed) one more method.

We should have these covered by unit and system tests, but it won't hurt to check the code for those. Let me look..
Nope, I can't find any reference to the removed or deprecated code. So it looks fine from a code point of view.

I can see we have several Stripe automated tests, but I agree it's worth doing some manual testing on it too! I've added a note at the top of the PR, based on Filipe's comment.

[drummer83]

Hi all,

here is what I have tested:

• connect stripe account ✔️
• checkout using stripe with legacy checkout using card 4242 ✔️
• checkout using stripe with legacy checkout using card 3184 complete authentication ✔️
• checkout using stripe with legacy checkout using card 3184 fail authentication ✔️
• checkout using stripe with legacy checkout using a new card (4444) ✔️
• checkout using stripe with split checkout using card 4242 ✔️
• checkout using stripe with split checkout using card 3184 complete authentication ✔️
• checkout using stripe with split checkout using card 3184 fail authentication ✔️
• checkout using stripe with split checkout using a new card (4444) ❓
  • The very first time I tried to use a new card, I was not able to enter the card number. The input was kind of blocked. After some time it worked. Maybe some loading time issue? Could you please try this scenario @filipefurtad0? Card: 5555 5555 5555 4444 (regular Mastercard)
• back office orders using stripe and card 4242 ✔️
• back office orders using stripe and complete authentication with card 3184 ✔️
• back office orders using stripe and fail authentication with card 3184 ✔️
• back office orders using stripe and new card (4444) ✔️
• disconnect stripe account ✔️

Do you think anything else needs to be tested here? Please let me know.
Adding the feedback-needed label for now.

Thanks!

[filipefurtad0]

Hey @drummer83 ,

Great - thanks for the thorough testing!

checkout using stripe with split checkout using a new card (4444) question
The very first time I tried to use a new card, I was not able to enter the card number. The input was kind of blocked. After some time it worked. Maybe some loading time issue? Could you please try this scenario @filipefurtad0? Card: 5555 5555 5555 4444 (regular Mastercard)

I've tried to reproduce any related issue with the Stripe form, but it always worked as expected. On Firefox 107, and using card nr. 5555 5555 5555 4444:

• added card details on checkout (not saving the card); completed checkout - OK
• added card details on checkout (saving the card); completed checkout - OK; verified card was saved on customer account - OK
• deleted saved card - OK
• added the card on the customer account page - card is saved correctly OK
• selected the saved card on checkout, and completed order - OK

In addition to this, I feel it might be a good idea to check subscriptions and backoffice.

Subscriptions

• created a new subscription with a card requiring 3D authentication (x-3184) and another one with a card not requiring 3D (x-4242). Ran our awesome subscription testing routine ✨
  For the 3D- and non 3D auth card all emails arrived, and the orders were placed. In case of the 3D-auth card, an additional link was received per email, as expected. The payments appeared as captured in the Stripe dashboard. All good.

Backoffice
Placed two orders in the BO, as above, for the cards x-3184 and x-4242. All worked as expected. The payments appeared as captured in the Stripe dashboard.

I think we can merge this one!