Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voiding partial refunds does not work for Stripe payment method (both SCA and Connect) #5830

Open
filipefurtad0 opened this issue Jul 27, 2020 · 2 comments
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Jul 27, 2020

Description

Voiding of the initial payment of an order is possible for Stripe (SCA and Connect). If a partial refund has been issued, this is currently only possible for Stripe-Connect, this fails for Stripe-SCA (see issue #5829).

This issue reports on the existing bug concerning the voiding of partial refunds, after these were issued - This is currently not working for Stripe-SCA. It's not working for Stripe-Connect either, but this payment methods will be eventually discontinued.

Expected Behavior

Voiding partial refunds should be possible for Stripe SCA and Connect payment methods.

Actual Behaviour

Attempting to void a partial Stripe payment shows an error and does not cancel the refund (both SCA and Connect).

Steps to Reproduce

Customer (or Admin, in the BO)

  1. Place two orders with several items, using Stripe-SCA in one and Stripe-Connect in the other, as a payment method.

Admin
2. Edit the respective order, remove some items.
3. Go to Payments - there should be a given amount in credit owed.
4. Press "Credit" on the initial payment of the order. A second entry should appear under Payments.
5. Press the X (void) of the refund payment. See one of the messages below, for the respective payment method.

Animated Gif/Screenshot

Attempt to refund Stripe-Connect partial refund:

image.png

Attempt to refund Stripe-SCA partial refund:

image.png

Workaround

For Stripe-Connect a workaround may be to issue a full refund, cancel the order, and start over. This is not possible at the moment for SCA, but cancelling the order is.

Update: the shop may issue a new payment on that order and get that money back to the customer.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

  • Version used: v3.1.3
  • Browser name and version: Firefox 78
  • Operating System and version (desktop or mobile): Desktop Ubuntu 20.04

Possible Fix

I guess it is debatable whether a fix for this should necessarily involve both payment methods - probably not, as Stripe-Connect will be eventually discontinued. So I guess the fix should focus on Stripe-SCA.

@filipefurtad0 filipefurtad0 added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Jul 27, 2020
@luisramos0
Copy link
Contributor

I'd say this is an S4. On StripeSCA, users can issue a new payment on the order to get that money back to the customer. A refund in StripeSCA is anyway a new credit payment.

@filipefurtad0 filipefurtad0 added bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. and removed bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. labels Jul 27, 2020
@filipefurtad0
Copy link
Contributor Author

filipefurtad0 commented Jul 27, 2020

Good point @luisramos0,
updated the Workaround section above.

But I guess for this workaround the shop/admin will need the customers credit card data, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
Status: All the things 💤
Development

No branches or pull requests

2 participants