Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spree Upgrade] Fix pending specs in Order Syncer and Proxy Order (Subscriptions) #2788

Closed
luisramos0 opened this issue Sep 29, 2018 · 2 comments
Closed

[Spree Upgrade] Fix pending specs in Order Syncer and Proxy Order (Subscriptions) #2788

luisramos0 opened this issue Sep 29, 2018 · 2 comments
Assignees
@kristinalim

Comments

@luisramos0
Copy link
Contributor

luisramos0 commented Sep 29, 2018 •
edited
Loading

order_syncer_spec is broken with 9 broken specs.
These specs were made pending but need to be fixed at some point.

Move all specs in proxy_order_spec to pending (order syncer and proxy order are specific to subscriptions).

See #2789 and #2902 and #3071
luisramos0 added a commit to luisramos0/openfoodnetwork that referenced this issue Sep 29, 2018
@luisramos0
Making broken OrderSyncerSpec tests pending, 9 tests to be fixed in i…
e79d184 
…ssue openfoodfoundation#2788
@luisramos0 luisramos0 mentioned this issue Sep 29, 2018
Merged
luisramos0 added a commit to luisramos0/openfoodnetwork that referenced this issue Sep 29, 2018
@luisramos0
Making broken OrderSyncerSpec tests pending, 9 tests to be fixed in i…
f5cb799 
…ssue openfoodfoundation#2788
luisramos0 added a commit to luisramos0/openfoodnetwork that referenced this issue Oct 4, 2018
@luisramos0
Making broken OrderSyncerSpec tests pending, 9 tests to be fixed in i…
bcbdd12 
…ssue openfoodfoundation#2788
sauloperez added a commit that referenced this issue Oct 8, 2018
@sauloperez
Merge pull request #2789 from luisramos0/pending_order_syncer
2aeed97 
[Spree Upgrade] Making broken OrderSyncerSpec tests pending, 9 tests to be fixed in issue #2788
@luisramos0 luisramos0 mentioned this issue Oct 21, 2018
Merged
@luisramos0 luisramos0 changed the title [Spree Upgrade] Fix Order Syncer specs (pending specs) [Spree Upgrade] Fix pending specs in Order Syncer and Proxy Order (Subscriptions) Oct 23, 2018
@luisramos0 luisramos0 mentioned this issue Nov 17, 2018
Merged
@kristinalim kristinalim self-assigned this Feb 23, 2019
@daniellemoorhead
Copy link
Contributor

If this is blocked and can't be worked on (and thus not In Dev) should it be moved back into the Spree Upgrade backlog until it's unblocked? Ping @kristinalim 😄

@kristinalim
Copy link
Member

Fixing just the parts of the blocker issue #2696 that fix this one. I moved #2696 to In Dev as well.

And reversed the other dependency relationship, so this one blocks #3410.

Sorry!

@kristinalim kristinalim mentioned this issue Feb 27, 2019
Merged
@kristinalim kristinalim mentioned this issue Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristinalim kristinalim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kristinalim @sigmundpetersen @luisramos0 @daniellemoorhead