Setting order cycle date from list persists wrong date

[sauloperez]

What

The date persisted in the order cycle doesn't match the one selected in the order cycle when doing so from the order cycles list. See the gif below:

Steps to reproduce

1. Go to order cycles
2. Modify a date of one of the available cycles through the datepicker
3. Click on the update button at the bottom of the page

Once reloaded the displayed date it's not the one we selected.

Acceptance Criteria

As an admin I want to see the actual date that I selected in the order cycle datepicker.

[kirstenalarsen]

wow, video bug reporting - I love it!

…

On 25 Oct 2017, at 2:45 AM, Pau Pérez Fabregat ***@***.***> wrote: What The date persisted in the order cycle doesn't match the one selected in the order cycle when doing so from the order cycles list. See the gif below: <https://camo.githubusercontent.com/d6025e1fca065703e0e6de19ad92a5d34d886cf2/687474703a2f2f672e7265636f726469742e636f2f654b4e735166775953302e676966> Steps to reproduce Go to order cycles Modify a date of one of the available cycles through the datepicker Click on the update button at the bottom of the page Once reloaded, the displayed it's not the one we selected. Acceptance Criteria As an admin I want to see the actual date that I selected in the order cycle datepicker. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1924>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACxryEMLNbIN5jWsdhVeracitsZWfBlCks5svgYVgaJpZM4QEpqX>.

[sigmundpetersen]

what tool are you using for recording @sauloperez ? 😄 #META

[sauloperez]

I have to admit I was on my good ol' mac 😅 using Recordit, but normally I use Peek in my daily day Ubuntu

[sauloperez]

The issue turned out to be due to a wrong translation of the key js_format. The date picker does not understand aa as year (año in Spanish). Changing it from aa-mm-dd to yy-mm-dd.

By quickly checking the locales I believe you will experience the same problem @myriamboure @ltrls and @sigmundpetersen. You have to stick to the English syntax (y, m, d).

[sigmundpetersen]

Changing it from aa-mm-dd to yy-mm-dd.

This worked on Scandinavian instance @sauloperez @myriamboure

[myriamboure]

@sauloperez @sigmundpetersen do we need to commit any PR or is it something we are supposed to do on our local server configuration ? Sorry non tech ;-)

[sauloperez]

It's just a translation that you need to change in Transifex. Look for https://github.com/openfoodfoundation/openfoodnetwork/blob/master/config/locales/fr.yml#L2079

[sigmundpetersen]

@sauloperez do you think these keys should be removed from en.yml as translation of them breaks functionality? 😄

There are 2 date picker keys spree.date_picker.js_format: yy-mm-dd and spree.date_picker.format: %Y-%M-%D

[sauloperez]

I wouldn't remove them as it seems to be the mechanism to localize the date format. For instance in Spain the standard is dd-mm-yyyy. Perhaps is worth adding a comment to note the special syntax cocumented in http://api.jqueryui.com/datepicker/#option-dateFormat

[myriamboure]

Standard in France is also dd-mm-yyyy :-)

[myriamboure]

That works in France ! Should we close that issue then @sauloperez ?

[daniellemoorhead]

@lin-d-hop @sineadfenton @NickWeir63 is this relevant for the UK instance?

[sineadfenton]

@daniellemoorhead No from testing now and work on order cycles last week I cant say this cropped up for me, so we look grand on this end.

[daniellemoorhead]

Thanks @sineadfenton then I imagine it would be ok to close this @sauloperez @myriamboure 😄