Find better names for constants and scopes

app/models/spree/order.rb

@@ -130,13 +130,16 @@ def states
       where("state != ?", state)
     }
 
+    # All the states of a complete order but that shouldn't count towards the balance (the customer
+    # didn't get the order for whatever reason). Note it does not include complete
+    FINALIZED_STATES = %w(canceled returned).freeze
     # All the states an order can be in before completing the checkout
-    PRIOR_TO_COMPLETION_STATES = %w(cart address delivery payment).freeze
-    # All the states of a complete order but that shouldn't count towards the balance. Those that
-    # the customer won't enjoy.
-    NON_FULFILLED_STATES = %w(canceled returned).freeze
+    UNFINALIZED_STATES = %w(cart address delivery payment).freeze
 
-    scope :in_incomplete_state, -> { where(state: PRIOR_TO_COMPLETION_STATES) }
+    scope :finalized, -> { where(state: FINALIZED_STATES) }
+    scope :unfinalized, -> { where(state: UNFINALIZED_STATES) }
+
+    scope :in_incomplete_state, -> { where(state: UNFINALIZED_STATES) }
 
     def self.by_number(number)
       where(number: number)

app/queries/customers_with_balance.rb

@@ -33,8 +33,7 @@ def left_join_complete_orders
   end
 
   def complete_orders
-    states = Spree::Order::PRIOR_TO_COMPLETION_STATES
-      .map { |state| Arel::Nodes.build_quoted(state) }
+    states = Spree::Order::UNFINALIZED_STATES.map { |state| Arel::Nodes.build_quoted(state) }
     Arel::Nodes::NotIn.new(Spree::Order.arel_table[:state], states)
   end
 end

app/queries/outstanding_balance.rb

@@ -34,7 +34,7 @@ def statement
   attr_reader :relation
 
   def non_fulfilled_states_group
-    states = Spree::Order::NON_FULFILLED_STATES.map { |state| Arel::Nodes.build_quoted(state) }
+    states = Spree::Order::FINALIZED_STATES.map { |state| Arel::Nodes.build_quoted(state) }
     Arel::Nodes::Grouping.new(states)
   end
 end