Use #dup when copying attributes hash

openfoodfoundation · Jun 30, 2020 · 707735b · 707735b
1 parent 57ba248
commit 707735b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/services/user_default_address_setter.rb b/app/services/user_default_address_setter.rb
@@ -9,15 +9,15 @@ def initialize(order, current_user)
 
   # Sets the order bill address as the user default bill address
   def set_default_bill_address
-    new_bill_address = @order.bill_address.clone.attributes
+    new_bill_address = @order.bill_address.dup.attributes
 
     set_bill_address_attributes(@current_user, new_bill_address)
     set_bill_address_attributes(@order.customer, new_bill_address)
   end
 
   # Sets the order ship address as the user default ship address
   def set_default_ship_address
-    new_ship_address = @order.ship_address.clone.attributes
+    new_ship_address = @order.ship_address.dup.attributes
 
     set_ship_address_attributes(@current_user, new_ship_address)
     set_ship_address_attributes(@order.customer, new_ship_address)