Merge pull request #2680 from luisramos0/2-0-stable-x

[Spree Upgrade] Fixed inexistent order#shipping_method= in several specs

lib/open_food_network/order_cycle_management_report.rb

@@ -107,7 +107,7 @@ def filter_to_payment_method(orders)
 
     def filter_to_shipping_method(orders)
       if params[:shipping_method_in].present?
-        orders.joins(:shipping_method).where(shipping_method_id: params[:shipping_method_in])
+        orders.joins(shipments: :shipping_methods).where(shipping_method_id: params[:shipping_method_in])
       else
         orders
       end

spec/controllers/spree/admin/orders/customer_details_controller_spec.rb

@@ -8,12 +8,12 @@
       let!(:user) { create(:user) }
       let(:address) { create(:address) }
       let!(:distributor) { create(:distributor_enterprise) }
-      let!(:shipping_method) { create(:shipping_method) }
+      let!(:shipment) { create(:shipment) }
       let!(:order) {
         create(
             :order_with_totals_and_distribution,
             state: 'cart',
-            shipping_method: shipping_method,
+            shipments: [shipment],
             distributor: distributor,
             user: nil,
             email: nil,
@@ -45,7 +45,7 @@
 
           order.reload
 
-          expect(response).to redirect_to spree.edit_admin_order_shipment_path(order, order.shipment)
+          expect(response).to redirect_to spree.admin_order_customer_path(order)
         end
       end
 
@@ -55,7 +55,7 @@
 
           order.reload
 
-          expect(response).to redirect_to spree.edit_admin_order_shipment_path(order, order.shipment)
+          expect(response).to redirect_to spree.admin_order_customer_path(order)
         end
       end
     end

spec/factories.rb

@@ -335,49 +335,73 @@
     end
   end
 
-  factory :shipping_method_with_flat_rate, parent: :shipping_method do
-    calculator { Spree::Calculator::FlatRate.new(preferred_amount: 50.0) }
-  end
+  factory :shipping_method_with, parent: :shipping_method do
+    trait :delivery do
+      require_ship_address { true }
+    end
 
-  factory :shipment_with_flat_rate, parent: :shipment do
-    after(:create) do |shipment|
-      shipment.add_shipping_method(create(:shipping_method_with_flat_rate), true)
+    trait :flat_rate do
+      calculator { Spree::Calculator::FlatRate.new(preferred_amount: 50.0) }
     end
-  end
 
-  factory :distributor_enterprise_with_tax, parent: :distributor_enterprise do
-    charges_sales_tax { true }
-    allow_order_changes { true }
-  end
+    trait :expensive_name do
+      name { "Shipping" }
+      description { "Expensive" }
+      calculator { Spree::Calculator::FlatRate.new(preferred_amount: 100.55) }
+    end
 
-  factory :shipping_method_with_shipping_fee, parent: :shipping_method do
-    transient do
-      shipping_fee 3
+    trait :distributor do
+      transient do
+        distributor { create :enterprise }
+      end
+      distributors { [distributor] }
     end
 
-    calculator { build(:calculator_per_item, preferred_amount: shipping_fee) }
-    require_ship_address { false }
-    distributors { [create(:distributor_enterprise_with_tax)] }
+    trait :shipping_fee do
+      transient do
+        shipping_fee 3
+      end
+
+      calculator { build(:calculator_per_item, preferred_amount: shipping_fee) }
+      require_ship_address { false }
+      distributors { [create(:distributor_enterprise_with_tax)] }
+    end
   end
 
-  factory :shipment_with_shipping_fee, parent: :shipment do
-    transient do
-      shipping_fee 3
+  factory :shipment_with, parent: :shipment do
+    trait :shipping_method do
+      transient do
+        shipping_method { create :shipping_method }
+      end
+      after(:create) do |shipment, evaluator|
+        shipment.add_shipping_method(evaluator.shipping_method, true)
+      end
     end
 
-    after(:create) do |shipment, evaluator|
-      shipping_method = create(:shipping_method_with_shipping_fee, shipping_fee: evaluator.shipping_fee)
-      shipment.add_shipping_method(shipping_method, true)
+    trait :shipping_fee do
+      transient do
+        shipping_fee 3
+      end
+
+      after(:create) do |shipment, evaluator|
+        shipping_method = create(:shipping_method_with, :shipping_fee, shipping_fee: evaluator.shipping_fee)
+        shipment.add_shipping_method(shipping_method, true)
+      end
     end
   end
 
+  factory :distributor_enterprise_with_tax, parent: :distributor_enterprise do
+    charges_sales_tax { true }
+    allow_order_changes { true }
+  end
+
   factory :completed_order_with_fees, parent: :order_with_totals_and_distribution do
     transient do
       shipping_fee 3
       payment_fee 5
     end
 
-    shipments { [ create(:shipment_with_shipping_fee, shipping_fee: shipping_fee) ] }
+    shipments { [ create(:shipment_with, :shipping_fee, shipping_fee: shipping_fee) ] }
 
     after(:create) do |order, evaluator|
       create(:line_item, order: order)

spec/features/admin/orders_spec.rb

@@ -149,7 +149,8 @@ def new_order_with_distribution(distributor, order_cycle)
     # Given a customer with an order, which includes their shipping and billing address
     @order.ship_address = create(:address, lastname: 'Ship')
     @order.bill_address = create(:address, lastname: 'Bill')
-    @order.shipping_method = create(:shipping_method, require_ship_address: true)
+    shipping_method = create(:shipping_method_with, :delivery)
+    @order.shipments << create(:shipment_with, :shipping_method, shipping_method: shipping_method)
     @order.save!
 
     # When I create a new order

spec/features/admin/reports_spec.rb

@@ -182,12 +182,13 @@
     let(:distributor2) { create(:distributor_enterprise, with_payment_and_shipping: true, charges_sales_tax: true) }
     let(:user1) { create_enterprise_user enterprises: [distributor1] }
     let(:user2) { create_enterprise_user enterprises: [distributor2] }
-    let(:shipping_method) { create(:shipping_method, name: "Shipping", description: "Expensive", calculator: Spree::Calculator::FlatRate.new(preferred_amount: 100.55)) }
+    let(:shipping_method) { create(:shipping_method_with, :expensive_name) }
+    let(:shipment) { create(:shipment_with, :shipping_method, shipping_method: shipping_method) }
     let(:enterprise_fee) { create(:enterprise_fee, enterprise: user1.enterprises.first, tax_category: product2.tax_category, calculator: Spree::Calculator::FlatRate.new(preferred_amount: 120.0)) }
     let(:order_cycle) { create(:simple_order_cycle, coordinator: distributor1, coordinator_fees: [enterprise_fee], distributors: [distributor1], variants: [product1.master]) }
 
     let!(:zone) { create(:zone_with_member) }
-    let(:order1) { create(:order, order_cycle: order_cycle, distributor: user1.enterprises.first, shipping_method: shipping_method, bill_address: create(:address)) }
+    let(:order1) { create(:order, order_cycle: order_cycle, distributor: user1.enterprises.first, shipments: [shipment], bill_address: create(:address)) }
     let(:product1) { create(:taxed_product, zone: zone, price: 12.54, tax_rate_amount: 0) }
     let(:product2) { create(:taxed_product, zone: zone, price: 500.15, tax_rate_amount: 0.2) }
 
@@ -395,15 +396,17 @@
     let(:distributor2) { create(:distributor_enterprise, with_payment_and_shipping: true, charges_sales_tax: true) }
     let(:user1) { create_enterprise_user enterprises: [distributor1] }
     let(:user2) { create_enterprise_user enterprises: [distributor2] }
-    let(:shipping_method) { create(:shipping_method, name: "Shipping", description: "Expensive", calculator: Spree::Calculator::FlatRate.new(preferred_amount: 100.55)) }
+    let(:shipping_method) { create(:shipping_method_with, :expensive_name) }
+    let(:shipment) { create(:shipment_with, :shipping_method, shipping_method: shipping_method) }
+
     let(:enterprise_fee1) { create(:enterprise_fee, enterprise: user1.enterprises.first, tax_category: product2.tax_category, calculator: Spree::Calculator::FlatRate.new(preferred_amount: 10)) }
     let(:enterprise_fee2) { create(:enterprise_fee, enterprise: user1.enterprises.first, tax_category: product2.tax_category, calculator: Spree::Calculator::FlatRate.new(preferred_amount: 20)) }
     let(:order_cycle) { create(:simple_order_cycle, coordinator: distributor1, coordinator_fees: [enterprise_fee1, enterprise_fee2], distributors: [distributor1], variants: [product1.master]) }
 
     let!(:zone) { create(:zone_with_member) }
     let(:country) { Spree::Country.find Spree::Config.default_country_id }
     let(:bill_address) { create(:address, firstname: 'Customer', lastname: 'Name', address1: 'customer l1', address2: '', city: 'customer city', zipcode: 1234, country: country) }
-    let(:order1) { create(:order, order_cycle: order_cycle, distributor: user1.enterprises.first, shipping_method: shipping_method, bill_address: bill_address) }
+    let(:order1) { create(:order, order_cycle: order_cycle, distributor: user1.enterprises.first, shipments: [shipment], bill_address: bill_address) }
     let(:product1) { create(:taxed_product, zone: zone, price: 12.54, tax_rate_amount: 0, sku: 'sku1') }
     let(:product2) { create(:taxed_product, zone: zone, price: 500.15, tax_rate_amount: 0.2, sku: 'sku2') }
 

spec/features/admin/shipping_methods_spec.rb

@@ -51,7 +51,9 @@
 
     scenario "deleting a shipping method referenced by an order" do
       o = create(:order)
-      o.shipping_method = @sm
+      shipment = create(:shipment)
+      shipment.add_shipping_method(@sm, true)
+      o.shipments << shipment
       o.save!
 
       visit_delete spree.admin_shipping_method_path(@sm)

spec/lib/open_food_network/customers_report_spec.rb

@@ -45,7 +45,7 @@ module OpenFoodNetwork
           a = create(:address)
           d = create(:distributor_enterprise)
           o = create(:order, distributor: d, bill_address: a)
-          o.shipping_method = create(:shipping_method)
+          o.shipments << create(:shipment)
 
           subject.stub(:orders).and_return [o]
           subject.table.should == [[

spec/lib/open_food_network/order_cycle_management_report_spec.rb

@@ -69,7 +69,8 @@ module OpenFoodNetwork
         let!(:oc1) { create(:simple_order_cycle) }
         let!(:pm1) { create(:payment_method, name: "PM1") }
         let!(:sm1) { create(:shipping_method, name: "ship1") }
-        let!(:order1) { create(:order, shipping_method: sm1, order_cycle: oc1) }
+        let!(:s1) { create(:shipment_with, :shipping_method, shipping_method: sm1) }
+        let!(:order1) { create(:order, shipments: [s1], order_cycle: oc1) }
         let!(:payment1) { create(:payment, order: order1, payment_method: pm1) }
 
         it "returns all orders sans-params" do
@@ -89,7 +90,6 @@ module OpenFoodNetwork
           pm3 = create(:payment_method, name: "PM3")
           order2 = create(:order, payments: [create(:payment, payment_method: pm2)])
           order3 = create(:order, payments: [create(:payment, payment_method: pm3)])
-          # payment2 = create(:payment, order: order2, payment_method: pm2)
 
           subject.stub(:params).and_return(payment_method_in: [pm1.id, pm3.id] )
           subject.filter(orders).should match_array [order1, order3]
@@ -98,8 +98,10 @@ module OpenFoodNetwork
         it "filters to a shipping method" do
           sm2 = create(:shipping_method, name: "ship2")
           sm3 = create(:shipping_method, name: "ship3")
-          order2 = create(:order, shipping_method: sm2)
-          order3 = create(:order, shipping_method: sm3)
+          s2 = create(:shipment_with, :shipping_method, shipping_method: sm2)
+          s3 = create(:shipment_with, :shipping_method, shipping_method: sm3)
+          order2 = create(:order, shipments: [s2])
+          order3 = create(:order, shipments: [s3])
 
           subject.stub(:params).and_return(shipping_method_in: [sm1.id, sm3.id])
           expect(subject.filter(orders)).to match_array [order1, order3]

spec/models/concerns/order_shipping_method_spec.rb

@@ -12,7 +12,8 @@
 
     context 'when order has single shipment' do
       it 'returns the shipments shipping_method' do
-        shipment = create(:shipment_with_flat_rate)
+        shipping_method = create(:shipping_method_with, :flat_rate)
+        shipment = create(:shipment_with, :shipping_method, shipping_method: shipping_method)
         order.shipments = [shipment]
 
         expect(order.shipping_method).to eq shipment.shipping_method

spec/models/proxy_order_spec.rb

@@ -77,7 +77,8 @@
 
   describe "resume" do
     let!(:payment_method) { create(:payment_method) }
-    let(:order) { create(:order_with_totals, shipping_method: create(:shipping_method)) }
+    let!(:shipment) { create(:shipment) }
+    let(:order) { create(:order_with_totals, shipments: [shipment]) }
     let(:proxy_order) { create(:proxy_order, order: order, canceled_at: Time.zone.now) }
     let(:order_cycle) { proxy_order.order_cycle }
 

spec/models/spree/adjustment_spec.rb

@@ -59,7 +59,8 @@ module Spree
       end
 
       describe "Shipment adjustments" do
-        let!(:shipment)       { create(:shipment_with_flat_rate) }
+        let(:shipping_method) { create(:shipping_method_with, :flat_rate) }
+        let(:shipment)        { create(:shipment_with, :shipping_method, shipping_method: shipping_method) }
         let!(:order)          { create(:order, distributor: hub, shipments: [shipment]) }
         let(:hub)             { create(:distributor_enterprise, charges_sales_tax: true) }
         let!(:line_item)      { create(:line_item, order: order) }

spec/models/spree/order_spec.rb

@@ -222,7 +222,8 @@
   end
 
   describe "getting the shipping tax" do
-    let(:shipment) { create(:shipment_with_flat_rate) }
+    let(:shipping_method) { create(:shipping_method_with, :flat_rate) }
+    let(:shipment) { create(:shipment_with, :shipping_method, shipping_method: shipping_method) }
     let(:order)    { create(:order, shipments: [shipment]) }
 
     context "with a taxed shipment" do
@@ -254,7 +255,8 @@
   end
 
   describe "getting the total tax" do
-    let(:shipment)       { create(:shipment_with_flat_rate) }
+    let(:shipping_method) { create(:shipping_method_with, :flat_rate) }
+    let(:shipment) { create(:shipment_with, :shipping_method, shipping_method: shipping_method) }
     let(:order)          { create(:order, shipments: [shipment]) }
     let(:enterprise_fee) { create(:enterprise_fee) }
     let!(:adjustment)    { create(:adjustment, adjustable: order, originator: enterprise_fee, label: "EF", amount: 123, included_tax: 2) }

spec/requests/checkout/paypal_spec.rb

@@ -5,9 +5,9 @@
 
   let!(:address) { create(:address) }
   let!(:shop) { create(:enterprise) }
-  let!(:shipping_method) { create(:shipping_method, distributor_ids: [shop.id]) }
-  let!(:order) { create(:order, distributor: shop, ship_address: address.dup, bill_address: address.dup) }
-  let!(:shipment) { create(:shipment, order: order, shipping_method: shipping_method) }
+  let!(:shipping_method) { create(:shipping_method_with, :distributor, distributor: shop) }
+  let!(:shipment) { create(:shipment_with, :shipping_method, shipping_method: shipping_method) }
+  let!(:order) { create(:order, distributor: shop, shipments: [shipment], ship_address: address.dup, bill_address: address.dup) }
   let!(:line_item) { create(:line_item, order: order, quantity: 3, price: 5.00) }
   let!(:payment_method) { Spree::Gateway::PayPalExpress.create!(name: "PayPalExpress", distributor_ids: [create(:distributor_enterprise).id], environment: Rails.env) }
   let(:params) { { token: 'lalalala', PayerID: 'payer1', payment_method_id: payment_method.id } }