feat: Add photo editing icon shortcut to product image viewer of nutrition facts page. #6422
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6422 +/- ##
==========================================
- Coverage 9.54% 5.83% -3.72%
==========================================
Files 325 490 +165
Lines 16411 29291 +12880
==========================================
+ Hits 1567 1710 +143
- Misses 14844 27581 +12737 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -116,6 +117,38 @@ class _EditProductImageViewerState extends State<EditProductImageViewer> | |||
| ), | |||
| ), | |||
| ), | |||
| PositionedDirectional( | |||
| bottom: 60.0, | |||
There was a problem hiding this comment.
Hey @may-tas
I believe the parent component has 20% vertical height, so using the fixed bottom might not be a great way to center the icon, in case of diff mobile height devices,
I might be wrong, but if possible, can you try the same UI in diff mobile devices ? Preferably on any emulator.
There was a problem hiding this comment.
I just followed the code logic other icons were using, I know this could lead to overflow, If you want I can change the approach, but then we would have to change others too.
There was a problem hiding this comment.
I have tested it in android emulator and my physical device it didnt overflow.
There was a problem hiding this comment.
Let me know if should change the approach here.
What :
Summary :
product_picture_banner.dartfile. This method provides a complete image editing experience including camera, gallery selection, and other image operations.ISSUE
Recording :
WhatsApp.Video.2025-03-07.at.15.49.59.mp4