Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Matomo event for user clicking on account deletion (issue #6351) #6410

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+12 −15
Open

feat: added Matomo event for user clicking on account deletion (issue #6351) #6410

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be46a1f
Added Matomo event for User clicking on account deletion
Mar 3, 2025
e4ad3e7
saving changes before rebase
Mar 4, 2025
abf30d7
Merge remote-tracking branch 'upstream/develop' into develop
Mar 6, 2025
ef85631
changes after review
Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/smooth_app/lib/helpers/analytics_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ enum AnalyticsEvent {
loginAction(tag: 'logged in', category: AnalyticsCategory.userManagement),
registerAction(tag: 'register', category: AnalyticsCategory.userManagement),
logoutAction(tag: 'logged out', category: AnalyticsCategory.userManagement),
accountDeletion(tag: 'user attempted account deletion', category: AnalyticsCategory.userManagement),
couldNotScanProduct(
tag: 'could not scan product',
category: AnalyticsCategory.couldNotFindProduct,
Expand Down
22 changes: 16 additions & 6 deletions packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:flutter/material.dart';
import 'package:matomo_tracker/matomo_tracker.dart';
import 'package:openfoodfacts/openfoodfacts.dart';
import 'package:provider/provider.dart';
import 'package:smooth_app/data_models/user_management_provider.dart';
Expand Down Expand Up @@ -237,12 +238,21 @@ class UserPreferencesAccount extends AbstractUserPreferences {
),
_getListTile(
appLocalizations.account_delete,
() async => Navigator.push<void>(
context,
MaterialPageRoute<void>(
builder: (BuildContext context) => AccountDeletionWebview(),
),
),
() async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check line no 254 from the same file, that how we have done that

AnalyticsHelper.trackEvent(AnalyticsEvent.logoutAction);

I believe we can do something similar.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, did it the same way now. Thanks!

// Track Matomo event using the enum
MatomoTracker.instance.trackEvent(
eventInfo: EventInfo(
category: AnalyticsEvent.accountDeletion.category.tag,
action: AnalyticsEvent.accountDeletion.tag,
name: 'Clicked Delete Account'),
);
Navigator.push<void>(
context,
MaterialPageRoute<void>(
builder: (BuildContext context) => AccountDeletionWebview(),
),
);
},
Icons.delete,
),
_getListTile(
Expand Down
8 changes: 0 additions & 8 deletions packages/smooth_app/pubspec.lock
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this change is not needed, please revert

Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@ packages:
url: "https://pub.dev"
source: hosted
version: "2.0.3"
app_settings:
dependency: "direct main"
description:
name: app_settings
sha256: "476df1d85cec143c3d27dd1c7451629a59c0c5ccf70a0adcbfa92a0a2d928705"
url: "https://pub.dev"
source: hosted
version: "5.2.0"
app_store_apple_store:
dependency: "direct main"
description:
Expand Down
1 change: 0 additions & 1 deletion packages/smooth_app/pubspec.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here:
if this change is not needed, please revert

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm waiting for Edouard's response whether to include the 'app_settings' package in the pubspec.yaml or not. Then I'll make the final commits all-together.

Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ dependencies:
sqflite_common_ffi: 2.3.4+4
url_launcher: 6.3.1
visibility_detector: 0.4.0+2
app_settings: 5.2.0
diacritic: 0.1.6
app_store_shared:
path: ../app_store/shared
Expand Down