Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove underline from zoom controls. #9866

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

deveshidwivedi
Copy link
Contributor

What

This PR removes duplicate underlines from zoom controls in the map, ensuring cleaner appearance while maintaining underlines for other elements.

Screenshot

screenshot

Related issue(s) and discussion

Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.55%. Comparing base (dc04d18) to head (2f38270).
Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #9866    +/-   ##
========================================
  Coverage   49.54%   49.55%            
========================================
  Files          67       67            
  Lines       20650    20768   +118     
  Branches     4980     4999    +19     
========================================
+ Hits        10231    10291    +60     
- Misses       9131     9186    +55     
- Partials     1288     1291     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanegigandet stephanegigandet merged commit ed75176 into openfoodfacts:main Mar 6, 2024
13 checks passed
@deveshidwivedi deveshidwivedi deleted the leaflet-fix branch March 6, 2024 10:50
john-gom pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaflet controls are duplicated in the packager code maps
3 participants