fix: js and json lang quotes escape #9822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Product Page
📦 Packaging
alexgarel
force-pushed
the
fix-js-lang-quotes-escape
branch
from
1baeaba to
012b8f2
Compare
|
This is a big PR ! I still have to double read my changes to be sure. |
alexgarel
commented
Feb 21, 2024
templates/api/knowledge-panels/contribution/data_quality_tags.tt.json
Outdated
Show resolved
Hide resolved
|
Ideally we should add a check that we don't use lang / f_lang without edq or esq if we are inside quotes. (but I don't think of an easy way to do this). |
|
This is ready for review & merge @stephanegigandet |
lib/ProductOpener/Display.pm
Outdated
| @@ -5736,12 +5740,21 @@ sub search_and_export_products ($request_ref, $query_ref, $sort_by) { | |||
| return; | |||
| } | |||
|
|
|||
| sub escape_char($s, $char) { | |||
There was a problem hiding this comment.
Looks good. Maybe this function (and escape_single_quote) could be moved to Text.pm
stephanegigandet
approved these changes
Feb 26, 2024
|
|
john-gom
pushed a commit
that referenced
this pull request
May 24, 2024
Translations coming from crowdin might contain single quotes or double quotes. So whenever we use lang in a json or javascript string we should escape quotes. I created edq and esq (Escape Single/Double Quotes) function for that (1st commit) and applied it in a lot of place (2nd commit). This should be the pattern to use from now on. fixes: - #9820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translations coming from crowdin might contain single quotes or double quotes. So whenever we use lang in a json or javascript string we should escape quotes.
I created edq and esq (Escape Single/Double Quotes) function for that (1st commit) and applied it in a lot of place (2nd commit). This should be the pattern to use from now on.
fixes:
Note: I will do a hotfix in prod for the remove account case, because it's important to fix quickly (GDPR).