Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Wikidata knowledge panel #17

Merged
merged 21 commits into from
Sep 2, 2022
Merged

feat: Wikidata knowledge panel #17

merged 21 commits into from
Sep 2, 2022

Conversation

sumit-158
Copy link
Member

@sumit-158 sumit-158 commented Aug 1, 2022 •
edited
Loading

What

  • will return wikidata knowledge panel
  • data that fetching form wikidata are label , description and image url

Fixes bug(s)

@sumit-158 sumit-158 marked this pull request as ready for review August 5, 2022 11:25
@teolemon teolemon changed the title Wikidata knowledege panel feat: Wikidata knowledge panel Aug 15, 2022
@sumit-158 sumit-158 linked an issue Aug 16, 2022 that may be closed by this pull request
Knowledge panel for Wikidata (taxonomy) #11
Closed
alexgarel
alexgarel requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.
The only think which is mandatory to change is the test, better not rely on an external server.

app/knowledge_panels.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/off.py Outdated Show resolved Hide resolved
app/off.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Show resolved Hide resolved
alexgarel
alexgarel reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

app/knowledge_panels.py Outdated Show resolved Hide resolved
app/off.py Outdated Show resolved Hide resolved
app/off.py Outdated Show resolved Hide resolved
alexgarel
alexgarel requested changes Aug 26, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment https://github.com/openfoodfacts/facets-knowledge-panels/pull/17/files#r956294507

@teolemon teolemon mentioned this pull request Aug 28, 2022
Open
@alexgarel
feat: translate wikidata panel
9bbdf71 
fix: wikipedia url was not predictably computed
test: use a fixture for active_translation
alexgarel
alexgarel reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ok now.

@sumit-158
Copy link
Member Author

Lets merge it! 🚀

@sumit-158 sumit-158 merged commit 9f08916 into main Sep 2, 2022
@sumit-158 sumit-158 deleted the taxonomy_data_kp branch September 2, 2022 14:27
@github-actions github-actions bot mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@teolemon teolemon Awaiting requested review from teolemon

Assignees

@sumit-158 sumit-158

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knowledge panel for Wikidata (taxonomy)
3 participants
@sumit-158 @alexgarel @teolemon