-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mentions of ListUsers excluded users #769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rhamzeh
previously approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a follow-up we can add the documentation to note this so that users are aware
rhamzeh
approved these changes
Jun 14, 2024
rhamzeh
previously approved these changes
Jun 14, 2024
jon-whit
reviewed
Jun 14, 2024
jon-whit
reviewed
Jun 14, 2024
jon-whit
reviewed
Jun 14, 2024
jon-whit
previously approved these changes
Jun 14, 2024
rhamzeh
previously approved these changes
Jun 17, 2024
rhamzeh
added a commit
that referenced
this pull request
Jun 17, 2024
the update is blocked by merging in #769 first
@willvedd can you update openfga/sdk to v0.5.0 as part of this? (not a requirement to merge) |
willvedd
commented
Jun 17, 2024
rhamzeh
approved these changes
Jun 18, 2024
ewanharris
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes all mentions of
excluded_users
in the context of the ListUsers API. This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g.user:*
) as a means of being abundantly clear about what auser:*
result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-addexcluded_users
at some point in the future but may or may not be a flattened list as previously implemented.References
Removal from API: openfga/api#171
Review Checklist
main