Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix validation of object IDs #348

Merged
merged 6 commits into from
Sep 25, 2024
Merged

fix: fix validation of object IDs #348

merged 6 commits into from
Sep 25, 2024

Conversation

ttrzeng
Copy link
Contributor

@ttrzeng ttrzeng commented Sep 16, 2024 •
edited by rhamzeh
Loading

Description

References

Closes #343

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ttrzeng ttrzeng requested review from a team as code owners September 16, 2024 16:36
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

ewanharris
ewanharris previously approved these changes Sep 23, 2024
View reviewed changes
@rhamzeh rhamzeh changed the title fix(openfga): fix Rule.id regex validation fix: fix Rule.id regex validation Sep 25, 2024
@ttrzeng ttrzeng requested a review from ewanharris September 25, 2024 15:13
@rhamzeh rhamzeh changed the title fix: fix Rule.id regex validation fix: fix validation of object IDs Sep 25, 2024
@rhamzeh rhamzeh added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit dc0d9f1 Sep 25, 2024
20 checks passed
@rhamzeh rhamzeh deleted the DX-50 branch September 25, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex bug for Rules.id and validator.user(value)
3 participants
@ttrzeng @rhamzeh @ewanharris