Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactoring Grammar #22

Closed
wants to merge 1 commit into from
Closed

fix: Refactoring Grammar #22

wants to merge 1 commit into from

Conversation

d-jeffery
Copy link
Contributor

@d-jeffery d-jeffery commented Aug 9, 2023 •
edited
Loading

Description

  • Shelving this change, but keeping the pull request. Will revisit after porting over the test suite from syntax-transformer.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery mentioned this pull request Aug 10, 2023
Open
@rhamzeh
Copy link
Member

rhamzeh commented Jan 22, 2024

Do we still need this?

@d-jeffery
Copy link
Contributor Author

Do we still need this?

Nope, closing.

@d-jeffery d-jeffery closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-jeffery @rhamzeh