Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The README example in Go-SDK uses inconsistent name. #91

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

HeroicHorizon
Copy link
Contributor

@HeroicHorizon HeroicHorizon commented Apr 30, 2024

References

closes #48

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main

@HeroicHorizon HeroicHorizon requested review from a team as code owners April 30, 2024 13:13
Copy link

linux-foundation-easycla bot commented Apr 30, 2024

CLA Signed

  • ✅login: balaji-dongare / (773c647)

The committers listed above are authorized under a signed CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.51%. Comparing base (d27ef8f) to head (773c647).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   22.51%   22.51%           
=======================================
  Files          94       94           
  Lines        9758     9758           
=======================================
  Hits         2197     2197           
  Misses       7308     7308           
  Partials      253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @balaji-dongare!

@rhamzeh rhamzeh added this pull request to the merge queue Apr 30, 2024
Merged via the queue into openfga:main with commit b6a8881 Apr 30, 2024
5 checks passed
@HeroicHorizon HeroicHorizon deleted the FixREADME branch September 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example for writeTuples should refer to body rather than requestBody
3 participants