-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not call read auth model on batchcheck and write #78
Conversation
a2f6214
to
abe6884
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 22.51% 22.49% -0.03%
==========================================
Files 94 94
Lines 9758 9750 -8
==========================================
- Hits 2197 2193 -4
+ Misses 7308 7306 -2
+ Partials 253 251 -2 ☔ View full report in Codecov by Sentry. |
…ansaction and improve tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2790f77
(#78)
can be removed
Co-authored-by: Raghd Hamzeh <[email protected]>
Description
Removes the read auth model call in BatchCheck/Write and replaces it with checking and returning an invalid model id error and then returning an invalid auth error if one arises.
References
Part of openfga/sdk-generator#314
Review Checklist
main