Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(OpenTelemetry): move to public API #122

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

evansims
Copy link
Member

Description

This fixes an issue wherein the telemetry reporting APIs were mistakenly marked/placed into the internal namespace rather than the public API.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the enhancement New feature or request label Sep 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.45%. Comparing base (6a4aa1a) to head (22439f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   25.45%   25.45%           
=======================================
  Files         102      102           
  Lines       10576    10576           
=======================================
  Hits         2692     2692           
  Misses       7612     7612           
  Partials      272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review September 23, 2024 04:47
@evansims evansims requested a review from a team as a code owner September 23, 2024 04:47
@evansims evansims added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 8fe8b4f Sep 23, 2024
8 checks passed
@evansims evansims deleted the refactor/otel/move-to-public-api branch September 23, 2024 14:11
@evansims evansims mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants