Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix out-dated document of ClientTupleKey #113

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Code2Life
Copy link
Contributor

ClientTupleKey type had changed, but readme file is still &[]ClientTupleKey

Description

References

Review Checklist

  • [√] I have clicked on "allow edits by maintainers".
  • [√] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • [√] The correct base branch is being used, if not main
  • [√] I have added tests to validate that the change in functionality is working as expected

@Code2Life Code2Life requested review from a team as code owners July 23, 2024 11:09
@rhamzeh
Copy link
Member

rhamzeh commented Aug 29, 2024

Thanks @Code2Life!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.45%. Comparing base (0887f1c) to head (cc299ce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   25.45%   25.45%           
=======================================
  Files         102      102           
  Lines       10576    10576           
=======================================
  Hits         2692     2692           
  Misses       7612     7612           
  Partials      272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhamzeh rhamzeh added this pull request to the merge queue Aug 29, 2024
Merged via the queue into openfga:main with commit 74964e8 Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants