chore: add mocks generation to Makefile #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3talsmith
changed the title
sergiught
reviewed
Jan 5, 2024
rhamzeh
changed the title
rhamzeh
changed the title
rhamzeh
requested changes
Jan 5, 2024
There was a problem hiding this comment.
@m3talsmith can you please squash all commits into one when you are good to go?
You can title it chore: add mocks generation to Makefile
7 tasks
m3talsmith
force-pushed
the
chore-add-mocks-generator
branch
from
2f9672f
to
3133fb0
Compare
rhamzeh
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current codebase has generated mocks that come from another codebase. To ensure reproducibility and maintain a good foundation for our tests, we've added a make task to generate the mocks from said codebase.
References
Review Checklist
main