This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Fix namespace for metrics invocations (#700) #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http-proxy-middleware is now required for local testing instead of setting "proxy" in package.json Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
The metrics for OpenFaaS now have a namespace suffix so that it is needed when looking up Prometheus metrics. This change also fixes the proxy issue with create-react-app now deprecating proxy settings in the package.json Fixes: #700 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Waterdrips
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix namespace for metrics invocations (#700)
How Has This Been Tested?
Tested before/after with OFC on my RPi - as set up by @Waterdrips. I swapped the image and tested the dashboard locally via
yarn start- this gave the expected metrics.How are existing users impacted? What migration steps/scripts do we need?
Updating the image should be enough.