default go module to on #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @alexellis |
alexellis
reviewed
Nov 3, 2021
README.md
Outdated
| @@ -27,8 +27,8 @@ The two templates are equivalent with `golang-http` using a structured request/r | |||
|
|
|||
| You can manage dependencies in one of the following ways: | |||
|
|
|||
| * To use Go modules without vendoring, add `--build-arg GO111MODULE=on` to `faas-cli up`, you can also use `--build-arg GOPROXY=https://` if you want to use your own mirror for the modules | |||
| * You can also Go modules with vendoring, run `go mod vendor` in your function folder and add `--build-arg GO111MODULE=on` to `faas-cli up` | |||
| * To use Go modules without vendoring, go module is enabled by default, you can also use `--build-arg GOPROXY=https://` if you want to use your own mirror for the modules | |||
There was a problem hiding this comment.
Can you bring those messages back and use them to say how to turn it off?
There was a problem hiding this comment.
sure, will update tomorrow my morning
alexellis
requested changes
Nov 3, 2021
Signed-off-by: Carlos Panato <[email protected]>
|
made the requested change, ptal |
alexellis
added a commit
that referenced
this pull request
Mar 2, 2022
Tested with local docker build, also enables Go modules as a default for golang-http, which was missing but meant to be enabled via #63 Fixes #67 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
alexellis
added a commit
that referenced
this pull request
Mar 2, 2022
Tested with local docker build, also enables Go modules as a default for golang-http, which was missing but meant to be enabled via #63 Fixes #67 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default golang template to always download go module
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Building with no
build argandgo modulesshould beon:Building with no
build arg --build-arg GO111MODULE=offandgo modulesshould beoffand use the vendor:I have:
git commit -sFixes #62