Updated install.sh to include iptables

[rvramesh]

Description

iptables dependency is required for debian bullseye support

Motivation and Context

• I have commented on issue faasd may have a compatibility issue with Debian Bullseye #227 to propose this change.

How Has This Been Tested?

Tested with Raspberry Pi 3 1GB Ram, Running latest Debian bullseye

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

• I've read the CONTRIBUTION guide
• My commit message has a body and describe how this was tested and why it is required.
• I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

• My code follows the code style of this project.
• I have added tests to cover my changes.

Docs:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[alexellis]

@rvramesh @jsiebens what happens on Ubuntu 20.x where you force it to install iptables, despite it being there already? Is there a package for iptables?

What I'm asking is - if in fixing Bullseye / Raspberry Pi, do we break anything for the more common case of Ubuntu?

[rvramesh]

@rvramesh @jsiebens what happens on Ubuntu 20.x where you force it to install iptables, despite it being there already? Is there a package for iptables?

What I'm asking is - if in fixing Bullseye / Raspberry Pi, do we break anything for the more common case of Ubuntu?

Great point. My assumption is that apt install iptables will cause nothing or update to latest version for that OS. I don't have a ubuntu setup to validate it though.

[rvramesh]

@rvramesh @jsiebens what happens on Ubuntu 20.x where you force it to install iptables, despite it being there already? Is there a package for iptables?

1. When we install a package which is already installed, it will skip or will get upgraded (https://askubuntu.com/questions/1068331/what-will-happen-if-i-install-the-same-package-twice-for-example-the-ubuntu-des)
2. The ubuntu repository contains the package for iptables https://packages.ubuntu.com/search?keywords=iptables

[alexellis]

I don't have a ubuntu setup to validate it though.

I can't see how that would be a problem because anyone can create an Ubuntu VM with multipass or by launching a droplet on DigitalOcean or a similar cloud.

This should take you less than 5-10 minutes to verify.

[alexellis]

See comments.

[rvramesh]

Hi @alexellis Thank you for the comments. I have resolved them. I am getting the changes tested in Ubuntu 20.04 LTS. Will keep this thread updated on the result.

[rvramesh]

Hi @alexellis in the install.sh at line 15 curl is used to fetch the version and display it. In the Ubuntu 20.04 LTS, i had to install it before running the script else it failed. Once curl is installed then the entire installation went smooth.

Question

Can the below code be moved into install_faasd method?

version=""

echo "Finding latest version from GitHub"
version=$(curl -sI https://github.com/$OWNER/$REPO/releases/latest | grep -i "location:" | awk -F"/" '{ printf "%s", $NF }' | tr -d '\r')
echo "$version"

if [ ! $version ]; then
  echo "Failed while attempting to get latest version"
  exit 1
fi

[alexellis]

Can the below code be moved into install_faasd method?

I need some context to understand why you're asking to do this? What's the benefit, what's the fix?

If curl needs to be added, then let's make sure that gets added early on with apt.

[alexellis]

Approved.

[alexellis]

It seems like we already add curl in the script?

[rvramesh]

It seems like we already add curl in the script?

At Line 15 the curl is used to fetch the version details. At line 201 the call to install the dependency happens. Hence curl is used before we would install the required dependency.