Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cron-connector chart to apps/v1 #559

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

Waterdrips
Copy link
Contributor

@Waterdrips Waterdrips commented Dec 3, 2019

Signed-off-by: Alistair Hey [email protected]

Description

Update cron-connector chart to use apps/v1 api rather than the 1.16 deprecated extensions/v1beta1

Motivation and Context

How Has This Been Tested?

Chart has been tested locally by creating static yaml ~(helm template) then applying to a 1.16 k8s cluster on DO

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@alexellis alexellis merged commit 9f00275 into openfaas:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants