Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-1147 - Footer #81

Merged
merged 20 commits into from
Mar 14, 2022
Merged

OEL-1147 - Footer #81

merged 20 commits into from
Mar 14, 2022

Conversation

escuriola
Copy link
Contributor

No description provided.

composer.json Outdated Show resolved Hide resolved
drishu
drishu previously approved these changes Mar 7, 2022
],
} %}

{% include '@oe-bcl/bcl-footer/bcl-footer.html.twig' with {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% include '@oe-bcl/bcl-footer/bcl-footer.html.twig' with {
{% include '@oe-bcl/footer' with {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in the other 3 templates.

@escuriola escuriola force-pushed the OEL-1147 branch 2 times, most recently from 01174d9 to 1018216 Compare March 14, 2022 10:07
Base automatically changed from OEL-1160 to 1.x March 14, 2022 10:54
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a duplicate div.col-12.col-lg-4
Screenshot 2022-03-14 at 16 08 21

@brummbar brummbar merged commit 0777c70 into 1.x Mar 14, 2022
@brummbar brummbar deleted the OEL-1147 branch March 14, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants